So I committed an initial go at the Microsoft Virtual Earth portion of things. It is by no means complete, but it seems to pass the initial tests. That is minus one problem Virtual Earth does not like to be in a floating div, it causes it to overflow the div. I''ve run into this problem before and the recommended course of action is normally to put it in a container div. I don''t think that really works in this case. Does anyone have any thoughts? -Kate
Hi Kate, The way I''ve noticed VE maps overflowing divs is that they don''t respect the width/height attributes from CSS. My solution has been to use inline styles. Are you referencing a different issue? Do you have any examples of a VE map overflowing? If a container div is the fix, you may be able to add it to the DOM programmatically inside the initialization code for the VE map. --Adam --- Adam DuVander I like maps: http://mapscripting.com I like simple: http://adamduvander.com On May 27, 2009, at 10:07 PM, Kate Chapman wrote:> So I committed an initial go at the Microsoft Virtual Earth portion > of things. It is by no means complete, but it seems to pass the > initial tests. That is minus one problem Virtual Earth does not > like to be in a floating div, it causes it to overflow the div. > I''ve run into this problem before and the recommended course of > action is normally to put it in a container div. I don''t think that > really works in this case. Does anyone have any thoughts? > > -Kate > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com
Hi Adam, Not sure why I missed that, simple inline style change and I was good to go. Thanks, Kate On May 28, 2009, at 1:28 AM, Adam DuVander wrote:> Hi Kate, > > The way I''ve noticed VE maps overflowing divs is that they don''t > respect the width/height attributes from CSS. My solution has been > to use inline styles. > > Are you referencing a different issue? Do you have any examples of a > VE map overflowing? > > If a container div is the fix, you may be able to add it to the DOM > programmatically inside the initialization code for the VE map. > > --Adam > --- > Adam DuVander > I like maps: http://mapscripting.com > I like simple: http://adamduvander.com > > On May 27, 2009, at 10:07 PM, Kate Chapman wrote: > >> So I committed an initial go at the Microsoft Virtual Earth portion >> of things. It is by no means complete, but it seems to pass the >> initial tests. That is minus one problem Virtual Earth does not >> like to be in a floating div, it causes it to overflow the div. >> I''ve run into this problem before and the recommended course of >> action is normally to put it in a container div. I don''t think >> that really works in this case. Does anyone have any thoughts? >> >> -Kate >> _______________________________________________ >> Mapstraction mailing list >> Mapstraction at lists.mapstraction.com >> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >
Awesome Kate! Thx - The need of inline styles vs. CSS styles with different providers is common issue. Probably needs to be part of the doc for each provider. will JSDoc pull in high-level documentation from proxy functions and then append notes from provider specific notes above methods? For example, the initialize for Microsoft could just have a JSDoc comment that discusses the styling issue. On Thu, May 28, 2009 at 7:09 AM, Kate Chapman <kate at maploser.com> wrote:> Hi Adam, > > Not sure why I missed that, simple inline style change and I was good to go. > > Thanks, > > Kate > > On May 28, 2009, at 1:28 AM, Adam DuVander wrote: > >> Hi Kate, >> >> The way I''ve noticed VE maps overflowing divs is that they don''t respect >> the width/height attributes from CSS. My solution has been to use inline >> styles. >> >> Are you referencing a different issue? Do you have any examples of a VE >> map overflowing? >> >> If a container div is the fix, you may be able to add it to the DOM >> programmatically inside the initialization code for the VE map. >> >> --Adam >> --- >> Adam DuVander >> I like maps: http://mapscripting.com >> I like simple: http://adamduvander.com >> >> On May 27, 2009, at 10:07 PM, Kate Chapman wrote: >> >>> So I committed an initial go at the Microsoft Virtual Earth portion of >>> things. ?It is by no means complete, but it seems to pass the initial tests. >>> ?That is minus one problem ?Virtual Earth does not like to be in a floating >>> div, it causes it to overflow the div. ?I''ve run into this problem before >>> and the recommended course of action is normally to put it in a container >>> div. ?I don''t think that really works in this case. ?Does anyone have any >>> thoughts? >>> >>> -Kate >>> _______________________________________________ >>> Mapstraction mailing list >>> Mapstraction at lists.mapstraction.com >>> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >> > > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >-- Andrew Turner mobile: 248.982.3609 andrew at fortiusone.com http://highearthorbit.com http://geocommons.com Helping build the Geospatial Web Introduction to Neogeography - http://oreilly.com/catalog/neogeography
Just had a look at that commit - I don''t think the code should explicitly set position to relative on the element, that might break the user''s layout and they won''t know why. It would be better to just mention the issue in the documentation and let the user figure it out for themselves. By "the user" i mean the dev using mapstraction to build their site. JSDoc won''t do what we want out-of-the-box, we''ll probably need to hack it unfortunately. Derek On Thu, May 28, 2009 at 12:46 PM, Andrew Turner <andrew at highearthorbit.com>wrote:> Awesome Kate! Thx - > > The need of inline styles vs. CSS styles with different providers is > common issue. Probably needs to be part of the doc for each provider. > > will JSDoc pull in high-level documentation from proxy functions and > then append notes from provider specific notes above methods? > > For example, the initialize for Microsoft could just have a JSDoc > comment that discusses the styling issue. > > > > On Thu, May 28, 2009 at 7:09 AM, Kate Chapman <kate at maploser.com> wrote: > > Hi Adam, > > > > Not sure why I missed that, simple inline style change and I was good to > go. > > > > Thanks, > > > > Kate > > > > On May 28, 2009, at 1:28 AM, Adam DuVander wrote: > > > >> Hi Kate, > >> > >> The way I''ve noticed VE maps overflowing divs is that they don''t respect > >> the width/height attributes from CSS. My solution has been to use inline > >> styles. > >> > >> Are you referencing a different issue? Do you have any examples of a VE > >> map overflowing? > >> > >> If a container div is the fix, you may be able to add it to the DOM > >> programmatically inside the initialization code for the VE map. > >> > >> --Adam > >> --- > >> Adam DuVander > >> I like maps: http://mapscripting.com > >> I like simple: http://adamduvander.com > >> > >> On May 27, 2009, at 10:07 PM, Kate Chapman wrote: > >> > >>> So I committed an initial go at the Microsoft Virtual Earth portion of > >>> things. It is by no means complete, but it seems to pass the initial > tests. > >>> That is minus one problem Virtual Earth does not like to be in a > floating > >>> div, it causes it to overflow the div. I''ve run into this problem > before > >>> and the recommended course of action is normally to put it in a > container > >>> div. I don''t think that really works in this case. Does anyone have > any > >>> thoughts? > >>> > >>> -Kate > >>> _______________________________________________ > >>> Mapstraction mailing list > >>> Mapstraction at lists.mapstraction.com > >>> > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com > >> > > > > _______________________________________________ > > Mapstraction mailing list > > Mapstraction at lists.mapstraction.com > > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com > > > > > > -- > Andrew Turner > mobile: 248.982.3609 > andrew at fortiusone.com > http://highearthorbit.com > > http://geocommons.com Helping build the Geospatial Web > Introduction to Neogeography - http://oreilly.com/catalog/neogeography > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com >-- Derek Fowler m. +44 (0) 7966 512 369 e. dezfowler at gmail.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090528/4426aa75/attachment.htm>
Derek, I suppose that was rude of me to just change the users layout. I haven''t looked into it with all the providers but I think suggesting the map div be cased in another div is probably the best solution, which could be noted in the documentation. That way if the actual map div needs to be changed to something else it would be encased as well and would prevent some overflow across the providers. -Kate On May 28, 2009, at 7:57 AM, Derek Fowler wrote:> Just had a look at that commit - I don''t think the code should > explicitly set position to relative on the element, that might break > the user''s layout and they won''t know why. It would be better to > just mention the issue in the documentation and let the user figure > it out for themselves. By "the user" i mean the dev using > mapstraction to build their site. > > JSDoc won''t do what we want out-of-the-box, we''ll probably need to > hack it unfortunately. > > Derek > > On Thu, May 28, 2009 at 12:46 PM, Andrew Turner <andrew at highearthorbit.com > > wrote: > Awesome Kate! Thx - > > The need of inline styles vs. CSS styles with different providers is > common issue. Probably needs to be part of the doc for each provider. > > will JSDoc pull in high-level documentation from proxy functions and > then append notes from provider specific notes above methods? > > For example, the initialize for Microsoft could just have a JSDoc > comment that discusses the styling issue. > > > > On Thu, May 28, 2009 at 7:09 AM, Kate Chapman <kate at maploser.com> > wrote: > > Hi Adam, > > > > Not sure why I missed that, simple inline style change and I was > good to go. > > > > Thanks, > > > > Kate > > > > On May 28, 2009, at 1:28 AM, Adam DuVander wrote: > > > >> Hi Kate, > >> > >> The way I''ve noticed VE maps overflowing divs is that they don''t > respect > >> the width/height attributes from CSS. My solution has been to use > inline > >> styles. > >> > >> Are you referencing a different issue? Do you have any examples > of a VE > >> map overflowing? > >> > >> If a container div is the fix, you may be able to add it to the DOM > >> programmatically inside the initialization code for the VE map. > >> > >> --Adam > >> --- > >> Adam DuVander > >> I like maps: http://mapscripting.com > >> I like simple: http://adamduvander.com > >> > >> On May 27, 2009, at 10:07 PM, Kate Chapman wrote: > >> > >>> So I committed an initial go at the Microsoft Virtual Earth > portion of > >>> things. It is by no means complete, but it seems to pass the > initial tests. > >>> That is minus one problem Virtual Earth does not like to be in > a floating > >>> div, it causes it to overflow the div. I''ve run into this > problem before > >>> and the recommended course of action is normally to put it in a > container > >>> div. I don''t think that really works in this case. Does anyone > have any > >>> thoughts? > >>> > >>> -Kate > >>> _______________________________________________ > >>> Mapstraction mailing list > >>> Mapstraction at lists.mapstraction.com > >>> http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com > >> > > > > _______________________________________________ > > Mapstraction mailing list > > Mapstraction at lists.mapstraction.com > > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com > > > > > > -- > Andrew Turner > mobile: 248.982.3609 > andrew at fortiusone.com > http://highearthorbit.com > > http://geocommons.com Helping build the Geospatial Web > Introduction to Neogeography - http://oreilly.com/catalog/neogeography > _______________________________________________ > Mapstraction mailing list > Mapstraction at lists.mapstraction.com > http://lists.mapstraction.com/listinfo.cgi/mapstraction-mapstraction.com > > > > -- > Derek Fowler > m. +44 (0) 7966 512 369 > e. dezfowler at gmail.com-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mapstraction.com/pipermail/mapstraction-mapstraction.com/attachments/20090529/aa4457de/attachment.htm>