Hello, in preparation for CentOS 6.5 I was trying to build Lustre 1.8 client on CentOS 6.4 updated with 2.6.32-431 kernel. Seems like recent changes in fs.h (/usr/src/kernels/2.6.32-431.el6.x86_64/include/linux/fs.h) is causing problems. make[5]: Entering directory `/usr/src/kernels/2.6.32-431.el6.x86_64'' cc1: warnings being treated as errors /root/rpmbuild/BUILD/lustre-1.8.9/lustre/llite/dir.c: In function ''ll_dir_ioctl'': /root/rpmbuild/BUILD/lustre-1.8.9/lustre/llite/dir.c:1288: error: assignment from incompatible pointer type /root/rpmbuild/BUILD/lustre-1.8.9/lustre/llite/dir.c:1360: error: passing argument 1 of ''putname'' from incompatible pointer type /usr/src/kernels/2.6.32-431.el6.x86_64/include/linux/fs.h:2170: note: expected ''struct filename *'' but argument is of type ''char *'' make[8]: *** [/root/rpmbuild/BUILD/lustre-1.8.9/lustre/llite/dir.o] Error 1 Any suggestions? Regards, -- Fredrik Nyström, National Supercomputer Centre freny-5UnqSh4Icw/LoDKTGw+V6w@public.gmane.org, +46 13 28 5718
Found this change that seems relevant:
Change If44cd9f9: LU-2800 llite: introduce local getname()
http://review.whamcloud.com/#/c/5781/
Lustre 1.8 client builds fine on 2.6.32-431.el6.x86_64 with following
patch applied to b1_8 from git://git.whamcloud.com/fs/lustre-release.git
------------------------------------------------------------------------
index ea1c93f..7e98af2 100644
--- a/lustre/llite/dir.c
+++ b/lustre/llite/dir.c
@@ -1177,6 +1177,30 @@ out:
return rc;
}
+static char *
+ll_getname(const char __user *filename)
+{
+ int ret = 0, len;
+ char *tmp = __getname();
+
+ if (!tmp)
+ return ERR_PTR(-ENOMEM);
+
+ len = strncpy_from_user(tmp, filename, PATH_MAX);
+ if (len == 0)
+ ret = -ENOENT;
+ else if (len > PATH_MAX)
+ ret = -ENAMETOOLONG;
+
+ if (ret) {
+ __putname(tmp);
+ tmp = ERR_PTR(ret);
+ }
+ return tmp;
+}
+
+#define ll_putname(filename) __putname(filename)
+
static int ll_dir_ioctl(struct inode *inode, struct file *file,
unsigned int cmd, unsigned long arg)
{
@@ -1285,7 +1309,7 @@ static int ll_dir_ioctl(struct inode *inode,
struct file *file,
if (cmd == IOC_MDC_GETFILEINFO ||
cmd == IOC_MDC_GETFILESTRIPE) {
- filename = getname((const char *)arg);
+ filename = ll_getname((const char *)arg);
if (IS_ERR(filename))
RETURN(PTR_ERR(filename));
@@ -1357,7 +1381,7 @@ static int ll_dir_ioctl(struct inode *inode,
struct file *file,
out_req:
ptlrpc_req_finished(request);
if (filename)
- putname(filename);
+ ll_putname(filename);
return rc;
}
case IOC_LOV_GETINFO: {
------------------------------------------------------------------------
Regards,
--
Fredrik Nyström, National Supercomputer Centre
freny-5UnqSh4Icw/LoDKTGw+V6w@public.gmane.org, +46 13 28 5718
On Tue, 2013-11-26 at 17:43 +0100, Fredrik Nyström wrote:> Hello, > > > in preparation for CentOS 6.5 I was trying to build Lustre 1.8 client on > CentOS 6.4 updated with 2.6.32-431 kernel.There is a ticket open to track this effort already: https://jira.hpdd.intel.com/browse/LU-4287 If you make any progress, you could help in this effort by posting to that ticket. Cheers, b.