pascal.deveze at bull.net
2009-Jul-07 07:42 UTC
[Lustre-discuss] [ROMIO Req #940] a new Lustre ADIO driver]
Rob,>> 2) The parameter len_list_ptr has been modified in include/adioi.h, so I >> propose to change : >> int **len_list_ptr; >> to >> ADIO_Offset **len_list_ptr; >> >> in ad_lustre_aggregate.c and ad_lustre_wrcoll.c> No argument here. That''s clearly the right thing to do. I''ve > committed that change. Take a look at revision 4889 and let me know > if I missed anythingAll your changes are OK on revision 4889. Concerning the other suggestions, I agree that they have to be discussed with gurus. My contribution, for the moment, was only to point out where the problemes seem to be.> Thanks much for including the patch. that''s a huge help when having > this kind of conversation. In the future, can you send it in "unified > diff" format (-u)? Also, you made four kinds of changes. I know how > much a pain it is, but is it possible next time to split up the patch > into four pieces, one for each topic?> Thanks for your help with the Lustre driver, and for fielding my > questions!> ==robI am just a newbie. I''ll be happy to take your advises into account for my future suggestions. Pascal