Bailey, Darragh
2007-Aug-16 08:13 UTC
[Lustre-discuss] is tcp-zero-copy kernel patch obsolete?
In lustre 1.4.11 I''ve noticed that there are still tcp-zero-copy patches in a number of the series files. /tmp/lustre-1.4.11/lustre/kernel_patches/series$ grep -r tcp * 2.6-rhel4-titech.series:new-tcp-zero-copy-2.6.9-41.2chaos.patch 2.6-sles10.series:new-tcp-zero-copy-2.6.16-sles10.patch 2.6-suse-newer.series:new-tcp-zero-copy-2.6.5-sles9.patch rhel-2.4.21:new-tcp-zero-copy-2.4.21-rhel3.patch vanilla-2.4.29:new-tcp-zero-copy-2.4.29-vanilla.patch vanilla-2.4.29-uml:new-tcp-zero-copy-2.4.29-vanilla.patch I assumed that this patch was now obsolete since lustre has been modified to work around this within the tcp stack. Following bugzilla''s appear to suggest the same as the reason for not fixing the bugs: https://bugzilla.lustre.org/show_bug.cgi?id=3627 https://bugzilla.lustre.org/show_bug.cgi?id=11102 Comment 5 in the following bugzilla states https://bugzilla.lustre.org/show_bug.cgi?id=11248#c5 "The tcp zero-copy patch can be removed now that the socklnd protocol has been updated to signal zero-copy send completions." Is this just a case that the changes haven''t been made to all the series files, or is it still required in certain cases? -- Regards, Darragh Bailey Systems Software Engineer Hewlett Packard Galway Ltd. +353 91 75-4674 Postal Address: Hewlett Packard Galway Limited, Ballybrit Business Park, Galway Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson''s Quay Dublin 2 Registered Number: 361933 _______________________________________________ The contents of this message and any attachments to it are confidential and may be legally privileged. If you have received this message in error you should delete it from your system immediately and advise the sender. To any recipient of this message within HP, unless otherwise stated you should consider this message and attachments as "HP CONFIDENTIAL".
Isaac Huang
2007-Aug-16 09:03 UTC
[Lustre-discuss] is tcp-zero-copy kernel patch obsolete?
On Thu, Aug 16, 2007 at 03:12:59PM +0100, Bailey, Darragh wrote:> > > In lustre 1.4.11 I''ve noticed that there are still tcp-zero-copy patches > in a number of the series files. > > /tmp/lustre-1.4.11/lustre/kernel_patches/series$ grep -r tcp * > 2.6-rhel4-titech.series:new-tcp-zero-copy-2.6.9-41.2chaos.patch > 2.6-sles10.series:new-tcp-zero-copy-2.6.16-sles10.patch > 2.6-suse-newer.series:new-tcp-zero-copy-2.6.5-sles9.patch > rhel-2.4.21:new-tcp-zero-copy-2.4.21-rhel3.patch > vanilla-2.4.29:new-tcp-zero-copy-2.4.29-vanilla.patch > vanilla-2.4.29-uml:new-tcp-zero-copy-2.4.29-vanilla.patch > > > I assumed that this patch was now obsolete since lustre has been > modified to work around this within the tcp stack.Yes, the patch is now useless.> > Following bugzilla''s appear to suggest the same as the reason for not > fixing the bugs: > https://bugzilla.lustre.org/show_bug.cgi?id=3627 > https://bugzilla.lustre.org/show_bug.cgi?id=11102 > > Comment 5 in the following bugzilla states > https://bugzilla.lustre.org/show_bug.cgi?id=11248#c5 > > "The tcp zero-copy patch can be removed now that the socklnd protocol > has been updated to signal zero-copy send completions." > > > Is this just a case that the changes haven''t been made to all the series > files, or is it still required in certain cases? >It''s not required anywhere now. It''s been removed from all series files for the upcoming 1.4.12, but somehow the change didn''t go into 1.4.11. Isaac