scjody at clusterfs.com
2007-Sep-19 22:38 UTC
[Lustre-devel] [Bug 12842] Module symbol versions broken with external ldiskfs
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=12842 (In reply to comment #26)> This somehow does not seem like the proper fix. The system Module.symvers > should not be touched. Our builds were failing due to this being owned by root. > This also violates rpm since rpm --verify on the kernel-devel will fail.OK. I will come up with a solution that doesn''t break these cases.> I have attached a patch that at least works for external ldiskfs builds (I have > not tested it on internal ldiskfs builds). The kernel documentation states that > if external module A depends on external module B you just have the > Module.symvers that was automatically created for module B in the top level > directory of module A at build time. The kernel will then output a new > Module.symvers that includes info on both modules.Which documentation? This is incorrect according to both Documentation/kbuild/modules.txt and my experiments. For example, on RHEL 4, ''make'' in the ldiskfs directory gives a Module.symvers files that contains only the symbols for the ldiskfs module. This file is never used when building Lustre modules, and there is no way to use it with the shipped version of modpost and Makefile.modpost.