shadow@clusterfs.com
2007-Feb-05 06:57 UTC
[Lustre-devel] [Bug 11647] patchless client for 2.6.20
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11647 Created an attachment (id=9505) Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: --> (https://bugzilla.lustre.org/attachment.cgi?id=9505&action=view) fixes for work lustre with 2.6.20 changes in kernel api 1) INIT_WORK need only 2 arguments 2) SLAB_ defines removed from kernel 3) truncate_compleate_page need cancel_dirty_page instead of clear_dirty_page.
adilger@clusterfs.com
2007-Feb-06 16:32 UTC
[Lustre-devel] [Bug 11647] patchless client for 2.6.20
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11647 What |Removed |Added ---------------------------------------------------------------------------- Attachment #9505|review?(adilger@clusterfs.co|review+ Flag|m) | (From update of attachment 9505)>+LB_LINUX_TRY_COMPILE([ >+ #include <linux/slab.h> >+],[ >+ #ifndef SLAB_KERNEL >+ #error SLAB_KERNEL do not defined >+ #endif >+],[Please fix indenting.>+],[ >+ struct writeback_control wb; >+ >+ wb.range_start = 0; >+],[Indenting.>+LB_LINUX_TRY_COMPILE([ >+ #include <linux/page-flags.h> >+],[ >+ cancel_dirty_page(NULL, 0); >+],[ >+ AC_MSG_RESULT(yes)Indenting>+# 2.6.20 >+LC_SLAB_KERNEL >+LC_SLAB_NOFS >+LC_WB_RANGE_START >+LC_CANCEL_DIRTY_PAGEAh, good. It is very useful to know what kernel version each configure check applies to, so we can eventually remove some of them.>diff -u -p -r1.1.6.3 lustre_patchless_compat.h >--- lustre/include/linux/lustre_patchless_compat.h 11 Dec 2006 11:18:15 -0000 1.1.6.3 >+++ lustre/include/linux/lustre_patchless_compat.h 5 Feb 2007 13:43:38 -0000 >@@ -46,7 +46,11 @@ truncate_complete_page(struct address_sp > if (PagePrivate(page)) > page->mapping->a_ops->invalidatepage(page, 0); > >- clear_page_dirty(page); >+#ifdef HAVE_CANCEL_DIRTY_PAGE >+ cancel_dirty_page(page, PAGE_SIZE); >+#else >+ clear_page_dirty(page); >+#endifIndenting, and this could also be a compat macro in lustre_compat25.h. Make the code look like the 2.6.20 function (cancel_dirty_page()) and eventually the old code will go away. Unfortunately, I don''t think this can land on b1_4 for a while, if at all. Instead email pmg@ and ask for a target date to land on b1_5.
shadow@clusterfs.com
2007-Feb-08 13:13 UTC
[Lustre-devel] [Bug 11647] patchless client for 2.6.20
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11647 What |Removed |Added ---------------------------------------------------------------------------- Attachment #9505 is|0 |1 obsolete| | Created an attachment (id=9548) Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: --> (https://bugzilla.lustre.org/attachment.cgi?id=9548&action=view) fix minor errors add support for RHEL5 kernel. fix indenting, add RHEL5 beta2 (and fc6 with 2.6.18 kernel) support.