Lustre devel - Jan 2007 - [Bug 11090] versioning check is incomplete

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugs@clusterfs.com          |bobijam@clusterfs.com


Created an attachment (id=9263)
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
 --> (https://bugzilla.lustre.org/attachment.cgi?id=9263&action=view)
version check for too new libclient

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9263|review?(green@clusterfs.com)|review+
               Flag|                            |


(From update of attachment 9263)
Teh patch is good. Though I am not sure if we should land it anywhere. There is
very little point in banning too new clients, they know how to work with old
servers or if they don''t, they would refuse to mount anyway.

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090



(In reply to comment #3)
> (From update of attachment 9263)
> Teh patch is good. Though I am not sure if we should land it anywhere.
There is
> very little point in banning too new clients, they know how to work with
old
> servers or if they don''t, they would refuse to mount anyway.
>       
This hasn''t been the case in my experience.  Depending on what the
exact new/old
versions have been too new clients fail in different ways.  In some cases they
just hang forever, don''t fail & exit.  Would much rather ban too
new clients
with a predictable, known error msg.  That''s why I submitted this bug.

Haven''t tried it yet, but patch looks OK to me.

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090



The patch shown works OK, but need additional changes to fixup the error message
in import.c
I suggest the following:

--- lustre/ptlrpc/import.c      (revision 4772)
+++ lustre/ptlrpc/import.c      (working copy)
@@ -679,13 +679,15 @@
                               never see this from VFS context */
                                 CERROR("Server %s version (%d.%d.%d.%d)
"
                                        "refused connection from this
client "
-                                       "as too old version (%s).  Client
must
"+                                       "as too %s version (%s). 
Client must "
                                        "be recompiled\n",
                                       obd2cli_tgt(imp->imp_obd),
                                      
OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
                                      
OBD_OCD_VERSION_MINOR(ocd->ocd_version),
                                      
OBD_OCD_VERSION_PATCH(ocd->ocd_version),
                                       OBD_OCD_VERSION_FIX(ocd->ocd_version),
+                                      ocd->ocd_version >
LUSTRE_VERSION_CODE ?
+                                        "old" : "new",
                                       LUSTRE_VERSION_STRING);
                                 ptlrpc_deactivate_import(imp);
                                 IMPORT_SET_STATE(imp, LUSTRE_IMP_CLOSED);


May also be some more change needed in import.c, where other ocd_version
checking is done.

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090



Created an attachment (id=9304)
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
 --> (https://bugzilla.lustre.org/attachment.cgi?id=9304&action=view)
suggested patch

attaching suggested patch since the text in the comment wrapped around oddly.

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11090

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #9304 is|0                           |1
           obsolete|                            |


Created an attachment (id=9305)
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
 --> (https://bugzilla.lustre.org/attachment.cgi?id=9305&action=view)
2nd try