David Blaikie via llvm-dev
2021-Jul-23 14:41 UTC
[llvm-dev] [RFC][Dwarf Library] Relocations for DWO sections
General premise sounds correct to me (that we shouldn't be processing those sections, etc). I've replied to the patch - thanks for taking a look at this! (out of curiosity: What are you using Split DWARF single mode for (if you can speak to the application)?) On Thu, Jul 22, 2021 at 9:10 PM Alexander Yermolovich via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hello > > I observed when DWARF Context is created for DWO object (split dwarf > single mode), that relocations for .debug_info are processed and are stored > in a map. This adds quite a bit of memory overhead. This doesn't seem like > it is needed for DWO Context. Context created through > API DWARFContext::getDWOContext. Am I missing something? > > Illustrative patch to fix this: > https://reviews.llvm.org/D106624 > > Thank you, > Alex > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210723/dc8588f5/attachment.html>
Alexander Yermolovich via llvm-dev
2021-Jul-23 17:17 UTC
[llvm-dev] [RFC][Dwarf Library] Relocations for DWO sections
Thanks for replying in the patch. Left my reply. We are using it to deal with dwarf relocation overflows. We considered DWARF64, but split dwarf seems like a more traveled path. As for single vs split my understanding is that single plays nicer with our build system ATM. ________________________________ From: David Blaikie <dblaikie at gmail.com> Sent: Friday, July 23, 2021 7:41 AM To: Alexander Yermolovich <ayermolo at fb.com> Cc: llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC][Dwarf Library] Relocations for DWO sections General premise sounds correct to me (that we shouldn't be processing those sections, etc). I've replied to the patch - thanks for taking a look at this! (out of curiosity: What are you using Split DWARF single mode for (if you can speak to the application)?) On Thu, Jul 22, 2021 at 9:10 PM Alexander Yermolovich via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello I observed when DWARF Context is created for DWO object (split dwarf single mode), that relocations for .debug_info are processed and are stored in a map. This adds quite a bit of memory overhead. This doesn't seem like it is needed for DWO Context. Context created through API DWARFContext::getDWOContext. Am I missing something? Illustrative patch to fix this: https://reviews.llvm.org/D106624<https://reviews.llvm.org/D106624> Thank you, Alex _______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210723/c298fabc/attachment.html>