David Blaikie via llvm-dev
2021-Jun-14 15:03 UTC
[llvm-dev] Review wanted - contribution for legacy pass manager (machine pass extensions)
Arthur - any idea who might be good to review this? On Mon, Jun 7, 2021 at 6:20 AM Raoul Gough via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hello llvm-dev, I have a code contribution for the legacy pass manager > and I'm having trouble finding anyone to finish reviewing it. I've made > some improvements based on earlier feedback from @ychen on Phabricator > but since then nobody has given final approval. Can anyone help with > this or point me in the right direction? > > I couldn't see anyone listed in the CODE_OWNERS.txt for this area of the > code base. From what I understand the new pass manager still doesn't > handle the target-specific code, so I think the code is in the right > place for now at least. I'd be happy to move it to the new pass manager > if that's currently possible, of course. > > This is related to my (out of tree) runtime inlining project and adds > minimal support for target-level extensions in a similar way to > addGlobalExtension in the legacy IR PassManagerBuilder... > https://reviews.llvm.org/D98591 > > Regards, > Raoul Gough. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210614/4e44ba51/attachment.html>
Arthur Eubanks via llvm-dev
2021-Jun-15 22:22 UTC
[llvm-dev] Review wanted - contribution for legacy pass manager (machine pass extensions)
I'm not super familiar with the codegen pipeline, perhaps some backend people can take a look? A question is, do we want extensions like in the middle-end optimization pipeline? I don't see why not, this mirrors the existing extensions for the optimization pipeline. But it'd be good to get some more opinions from people more knowledgeable. On Mon, Jun 14, 2021 at 8:04 AM David Blaikie <dblaikie at gmail.com> wrote:> Arthur - any idea who might be good to review this? > > On Mon, Jun 7, 2021 at 6:20 AM Raoul Gough via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hello llvm-dev, I have a code contribution for the legacy pass manager >> and I'm having trouble finding anyone to finish reviewing it. I've made >> some improvements based on earlier feedback from @ychen on Phabricator >> but since then nobody has given final approval. Can anyone help with >> this or point me in the right direction? >> >> I couldn't see anyone listed in the CODE_OWNERS.txt for this area of the >> code base. From what I understand the new pass manager still doesn't >> handle the target-specific code, so I think the code is in the right >> place for now at least. I'd be happy to move it to the new pass manager >> if that's currently possible, of course. >> >> This is related to my (out of tree) runtime inlining project and adds >> minimal support for target-level extensions in a similar way to >> addGlobalExtension in the legacy IR PassManagerBuilder... >> https://reviews.llvm.org/D98591 >> >> Regards, >> Raoul Gough. >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210615/fea78d2c/attachment.html>