Ben Shi via llvm-dev
2021-Jun-08 03:12 UTC
[llvm-dev] [proposal] change default ABI for special riscv arch
Hello, In the clang's riscv driver, https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Arch/RISCV.cpp the default abi is fomulated according to arch if no explicit -mabi is specified. Is it possible to set the default abi to ilp32f for -march=rv32imacf. For my exployer's chip, HW F is used while SW D is used. Each time I have to write "-march=rv32imacf -mabi=ilp32f“, can it be simplified to only "-march=imacf" ? Just adding a line is enough. if (MArch.substr(4).contains_lower("f") && !MArch.substr(4).contains_lower("d")) return "ilp32f"; Can I submit a patch to fix it? Ben -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210608/bcae44e7/attachment.html>
Craig Topper via llvm-dev
2021-Jun-08 04:06 UTC
[llvm-dev] [proposal] change default ABI for special riscv arch
That one line change doesn't look like it handles multiletter extension names correctly. For example, Zbf contains "f". ~Craig On Mon, Jun 7, 2021 at 8:13 PM Ben Shi via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Hello, > > In the clang's riscv driver, > > https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/ToolChains/Arch/RISCV.cpp > > the default abi is fomulated according to arch if no explicit -mabi is > specified. > > Is it possible to set the default abi to ilp32f for -march=rv32imacf. For > my exployer's chip, HW F is used while SW D is used. Each time I have to > write "-march=rv32imacf -mabi=ilp32f“, can it be simplified to only > "-march=imacf" ? Just adding a line is enough. > > if (MArch.substr(4).contains_lower("f") && !MArch.substr(4).contains_lower > ("d")) > return "ilp32f"; > > Can I submit a patch to fix it? > > Ben > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210607/ab923b91/attachment.html>