Djordje Todorovic via llvm-dev
2021-Jun-07 14:01 UTC
[llvm-dev] RFC: Reducing metadata in LLVM tests
Hi Adrian, I'm not opposed to adding something like this into the llvm-reduce (ReduceMetadata) utility, and I think it will be a better way. @Jeremy Morse<mailto:jeremy.morse at sony.com> has mentioned that someone from SONY is working on something like this -- I am happy with that and I just want to avoid redundant work. Best regards, Djordje ________________________________ From: Adrian Prantl <aprantl at apple.com> Sent: Friday, June 4, 2021 7:42 PM To: Djordje Todorovic <Djordje.Todorovic at syrmia.com> Cc: llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>; Jeremy Morse <jeremy.morse at sony.com>; Petar Jovanovic <petar.jovanovic at syrmia.com>; asowda at cisco.com <asowda at cisco.com>; ibaev at cisco.com <ibaev at cisco.com> Subject: Re: RFC: Reducing metadata in LLVM tests Hi Djordje, I think something like this would be super useful. Can you explain how it differs from the metadata reduction in bugpoint and to what degree the two share (or could share) code? -- adrian On Jun 4, 2021, at 7:06 AM, Djordje Todorovic <djordje.todorovic at syrmia.com<mailto:djordje.todorovic at syrmia.com>> wrote: Hi, We are seeing that the LLVM test suite grows every day, so there is always a need for reducing the new tests as well as the old ones. There are tools designed to do that, e.g. [0] and [1]. When an IR (or MIR) test contains Debug Info, the LLVM DI Metadata makes the test obviously longer. Not all of these metadata are always necessary for the test, so reviewers frequently ask patch submitters for a reduced test case in terms of DI Metadata by recommending some tricks described in [2]. The [2] is just a small proposal for a utility tool that will save us some time (when fully implemented) during making the patches as well as when doing code reviews -- any thoughts on this? [0] https://llvm.org/docs/CommandGuide/bugpoint.html [1] https://blog.regehr.org/archives/2109 [2] https://github.com/djolertrk/llvm-metadataburn Best regards, Djordje -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210607/94f8c3b8/attachment.html>
Hi Folks, I'm implementing DI metadata support for llvm-reduce as a part of my MSc project like @Morse, Jeremy<mailto:jeremy.morse at sony.com> mentioned. Thanks, Nabeel From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Djordje Todorovic via llvm-dev Sent: 07 June 2021 15:01 To: Adrian Prantl <aprantl at apple.com> Cc: llvm-dev at lists.llvm.org; ibaev at cisco.com; Morse, Jeremy <jeremy.morse at sony.com>; asowda at cisco.com; Petar Jovanovic <petar.jovanovic at syrmia.com> Subject: Re: [llvm-dev] RFC: Reducing metadata in LLVM tests Hi Adrian, I'm not opposed to adding something like this into the llvm-reduce (ReduceMetadata) utility, and I think it will be a better way. @Jeremy Morse<mailto:jeremy.morse at sony.com> has mentioned that someone from SONY is working on something like this -- I am happy with that and I just want to avoid redundant work. Best regards, Djordje ________________________________ From: Adrian Prantl <aprantl at apple.com<mailto:aprantl at apple.com>> Sent: Friday, June 4, 2021 7:42 PM To: Djordje Todorovic <Djordje.Todorovic at syrmia.com<mailto:Djordje.Todorovic at syrmia.com>> Cc: llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>>; Jeremy Morse <jeremy.morse at sony.com<mailto:jeremy.morse at sony.com>>; Petar Jovanovic <petar.jovanovic at syrmia.com<mailto:petar.jovanovic at syrmia.com>>; asowda at cisco.com<mailto:asowda at cisco.com> <asowda at cisco.com<mailto:asowda at cisco.com>>; ibaev at cisco.com<mailto:ibaev at cisco.com> <ibaev at cisco.com<mailto:ibaev at cisco.com>> Subject: Re: RFC: Reducing metadata in LLVM tests Hi Djordje, I think something like this would be super useful. Can you explain how it differs from the metadata reduction in bugpoint and to what degree the two share (or could share) code? -- adrian On Jun 4, 2021, at 7:06 AM, Djordje Todorovic <djordje.todorovic at syrmia.com<mailto:djordje.todorovic at syrmia.com>> wrote: Hi, We are seeing that the LLVM test suite grows every day, so there is always a need for reducing the new tests as well as the old ones. There are tools designed to do that, e.g. [0] and [1]. When an IR (or MIR) test contains Debug Info, the LLVM DI Metadata makes the test obviously longer. Not all of these metadata are always necessary for the test, so reviewers frequently ask patch submitters for a reduced test case in terms of DI Metadata by recommending some tricks described in [2]. The [2] is just a small proposal for a utility tool that will save us some time (when fully implemented) during making the patches as well as when doing code reviews -- any thoughts on this? [0] https://llvm.org/docs/CommandGuide/bugpoint.html<https://urldefense.com/v3/__https:/llvm.org/docs/CommandGuide/bugpoint.html__;!!JmoZiZGBv3RvKRSx!pgL-WcuUHkT34ETitKYsYZZse3iovVMZSi0B7k3j7wAbkGmbfppl6f9HJbMeUUw$> [1] https://blog.regehr.org/archives/2109<https://urldefense.com/v3/__https:/blog.regehr.org/archives/2109__;!!JmoZiZGBv3RvKRSx!pgL-WcuUHkT34ETitKYsYZZse3iovVMZSi0B7k3j7wAbkGmbfppl6f9HUio4nP0$> [2] https://github.com/djolertrk/llvm-metadataburn<https://urldefense.com/v3/__https:/github.com/djolertrk/llvm-metadataburn__;!!JmoZiZGBv3RvKRSx!pgL-WcuUHkT34ETitKYsYZZse3iovVMZSi0B7k3j7wAbkGmbfppl6f9HJxkDV6E$> Best regards, Djordje -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210607/b7294647/attachment.html>