David Blaikie via llvm-dev
2021-May-21 17:52 UTC
[llvm-dev] phabricator syntax highlighting update?
+Mehdi AMINI <joker.eph at gmail.com> On Fri, May 21, 2021 at 1:23 AM Jay Foad via llvm-dev < llvm-dev at lists.llvm.org> wrote:> Hi, > > I've noticed that the syntax highlighting for LLVM IR in diffs on > phabricator does not seem to know about some keywords like "bfloat". > Example here: https://reviews.llvm.org/D99261#change-LdztOV9pNerr > > I gather that phab uses pygments to do the highlighting, and pygments > was updated with this particular keyword here: > https://github.com/pygments/pygments/pull/1565 > > So could someone please update phabricator to use a newer version of > pygments? > > Thanks, > Jay. > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210521/9fe845ca/attachment.html>
Mehdi AMINI via llvm-dev
2021-May-21 18:03 UTC
[llvm-dev] phabricator syntax highlighting update?
Done: we were using the Ubuntu package, I removed it and switched to `pip3 install pygments` instead. On Fri, May 21, 2021 at 10:52 AM David Blaikie <dblaikie at gmail.com> wrote:> +Mehdi AMINI <joker.eph at gmail.com> > > On Fri, May 21, 2021 at 1:23 AM Jay Foad via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> Hi, >> >> I've noticed that the syntax highlighting for LLVM IR in diffs on >> phabricator does not seem to know about some keywords like "bfloat". >> Example here: https://reviews.llvm.org/D99261#change-LdztOV9pNerr >> >> I gather that phab uses pygments to do the highlighting, and pygments >> was updated with this particular keyword here: >> https://github.com/pygments/pygments/pull/1565 >> >> So could someone please update phabricator to use a newer version of >> pygments? >> >> Thanks, >> Jay. >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210521/330aea4a/attachment.html>