Kevin P. Neal via llvm-dev
2021-May-03 18:56 UTC
[llvm-dev] [RFC] Deprecate email code reviews in favor of Phabricator
On Mon, May 03, 2021 at 05:24:24PM +0000, Krzysztof Parzyszek via llvm-dev wrote:> This section presents a potential future evolution of the review > process. Christian has conducted experiments suggesting that we can > replace the XXX-commits mailing lists with notifications directly from > Phabricator:Wouldn't this make it more difficult for sites that archive the lists? Right now it all works. If the lists were eliminated then it would be harder to archive. Not impossible, but it would be more work. Plus, how long would it take for archive sites to switch over? How much history would only exist in Phab's database? Couldn't the commit lists be made read-only except from Phab? That would force reviews to happen on Phab but otherwise keep all existing email setups working. -- "A method for inducing cats to exercise consists of directing a beam of invisible light produced by a hand-held laser apparatus onto the floor ... in the vicinity of the cat, then moving the laser ... in an irregular way fascinating to cats,..." -- US patent 5443036, "Method of exercising a cat"
Michael Kruse via llvm-dev
2021-May-03 20:05 UTC
[llvm-dev] [cfe-dev] [RFC] Deprecate email code reviews in favor of Phabricator
Am Mo., 3. Mai 2021 um 13:56 Uhr schrieb Kevin P. Neal via cfe-dev <cfe-dev at lists.llvm.org>:> Couldn't the commit lists be made read-only except from Phab? That would > force reviews to happen on Phab but otherwise keep all existing email > setups working.I occasionally respond the email list to report a broken commit, especially if the commit was not based on a Phabriacator review. However, Phabricator also create a discussion page for each commit, I could just add a comment there. Is there still a discussion to eventually move to reviews on GitHub? That might have an influence on what we are going to do with *-commits mailing lists? Michael