Christian Kühnel via llvm-dev
2021-Apr-23 09:49 UTC
[llvm-dev] Anyone doing code reviews via mailing lists?
Hi folks, I just read in our Code Review policy <https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review>, that contributors can also do the code reviews on the mailing lists. I checked the XXX-commits mailing list archives since Feb 1st 2021 and could not find any code review there. I only found automatic emails from Phabricator reviews or git commits. Is anyone actually doing code reviews on the mailing list any more? Can you send me a link to a recent example? If nobody is doing code reviews on the mailing lists any more, we could also remove it from our policy... Best, Christian -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210423/af8d980a/attachment.html>
Philip Reames via llvm-dev
2021-Apr-23 14:47 UTC
[llvm-dev] Anyone doing code reviews via mailing lists?
It's not uncommon to have email responses to phab emails that don't make it into the web interface. A recent example is D99976. There's also a bunch of post commit discussion which happens entirely in email. Check any of the commit threads with responses in the last week. There are many. Philip On 4/23/2021 2:49 AM, Christian Kühnel via llvm-dev wrote:> Hi folks, > > I just read in our Code Review policy > <https://llvm.org/docs/CodeReview.html#what-tools-are-used-for-code-review>, > that contributors can also do the code reviews on the mailing lists. I > checked the XXX-commits mailing list archives since Feb 1st 2021 and > could not find any code review there. I only found automatic emails > from Phabricator reviews or git commits. > > Is anyone actually doing code reviews on the mailing list any more? > Can you send me a link to a recent example? > > If nobody is doing code reviews on the mailing lists any more, we > could also remove it from our policy... > > > Best, > Christian > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210423/20402c23/attachment.html>