Paul C. Anagnostopoulos via llvm-dev
2021-Apr-02 17:31 UTC
[llvm-dev] Test files with no checks
Ah, it's just to make sure nothing fails. Hmm. Okay, thanks! On 4/2/2021 1:24 PM, Craig Topper wrote:> That it will pass if tblgen doesn't return a non-zero exit status. > > ~Craig > > > On Fri, Apr 2, 2021 at 10:17 AM Paul C. Anagnostopoulos via llvm-dev > <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: > > What does it mean when there is a test file with no CHECK lines in it? > > An example is llvm/test/TableGen/ListSlices.td >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210402/b1a8054a/attachment.html>
We sometimes get tests like this to validate that a crash has been fixed - generally I try to push back on such tests because they seem underspecified to me: Presumably we want the program to have some specific behavior, not only "anything other than crashing" & the crash represents some lack of testing - some behavior behind/after the crash-point wasn't validated and probably should be validated. On Fri, Apr 2, 2021 at 10:31 AM Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > Ah, it's just to make sure nothing fails. Hmm. Okay, thanks! > > On 4/2/2021 1:24 PM, Craig Topper wrote: > > That it will pass if tblgen doesn't return a non-zero exit status. > > ~Craig > > > On Fri, Apr 2, 2021 at 10:17 AM Paul C. Anagnostopoulos via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> What does it mean when there is a test file with no CHECK lines in it? >> >> An example is llvm/test/TableGen/ListSlices.td > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev