Paul C. Anagnostopoulos via llvm-dev
2021-Jan-25 22:52 UTC
[llvm-dev] Git question about revert
I haven't found a "reopen differential." What's the right way to do that? At 1/25/2021 05:23 PM, Fangrui Song wrote:>* If the patch may take some time to reland or miss something more than > simple test tweaks, consider reopening the differential and (if > requires further review) requesting for changes.
If you go to a closed Phabricator review, the "Add Action" drop-down menu above where you write comments (where you can change reviewers/approve the patch etc), has a "Reopen Revision" action. Just select that and click submit to reopen (though I think Phabricator recently learnt to recognise pure reverts, so it may no longer be necessary, I'm not sure). On Mon, 25 Jan 2021 at 22:55, Paul C. Anagnostopoulos <paul at windfall.com> wrote:> I haven't found a "reopen differential." What's the right way to do that? > > At 1/25/2021 05:23 PM, Fangrui Song wrote: > > >* If the patch may take some time to reland or miss something more than > > simple test tweaks, consider reopening the differential and (if > > requires further review) requesting for changes. > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20210126/073b7aac/attachment.html>