Arthur Eubanks via llvm-dev
2020-Jul-28 01:11 UTC
[llvm-dev] Removing IPConstantPropagation.cpp
Should ConstantProp.cpp also be removed? It doesn't look like it's been worked on in over 10 years, and aside from check-llvm lit tests, the only use is in llvm/unittests/ExecutionEngine/MCJIT/MCJITAPITest.cpp via LLVMAddConstantPropagationPass. (it hasn't been ported to the new pass manager which is why I'm asking) On Mon, Jul 27, 2020 at 6:01 PM Chris Lattner via llvm-dev < llvm-dev at lists.llvm.org> wrote:> I’m ok removing it. The only utility I can see is as a simple > interprocedural pass for teaching people. I’m not sure that it is the best > thing to use for that. > > -Chris > > > On Jul 27, 2020, at 3:40 AM, Florian Hahn via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > Hi, > > > > As far as I know, the ipconstprop pass has not been actively used in > years and ipsccp has been used instead. This has the potential for > confusion and sometimes leads people to spend time finding & reporting bugs > as well as updating it to work with the latest API changes. > > > > If there are people actively using it, I would love to hear. > > > > If no-ones using it, I’d propose to remove the dead code: > https://reviews.llvm.org/D84447 > > > > Cheers, > > Florian > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200727/d1736899/attachment-0001.html>
Florian Hahn via llvm-dev
2020-Jul-28 15:15 UTC
[llvm-dev] Removing IPConstantPropagation.cpp
> On Jul 28, 2020, at 02:11, Arthur Eubanks <aeubanks at google.com> wrote: > > Should ConstantProp.cpp also be removed? It doesn't look like it's been worked on in over 10 years, and aside from check-llvm lit tests, the only use is in llvm/unittests/ExecutionEngine/MCJIT/MCJITAPITest.cpp via LLVMAddConstantPropagationPass. > (it hasn't been ported to the new pass manager which is why I'm asking)If it’s unused/not maintained I think we should also remove it or move it to the examples directory with some additional material, if it is intended to illustrate a simple pass. Cheers, Florian
Florian Hahn via llvm-dev
2020-Jul-30 11:41 UTC
[llvm-dev] Removing IPConstantPropagation.cpp
Thanks for all the comments. I push a commit removing the pass: e77624a . It is easy enough to bring it back if we discover some crucial use cases for it. Cheers, Florian> On Jul 28, 2020, at 16:15, Florian Hahn via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > >> On Jul 28, 2020, at 02:11, Arthur Eubanks <aeubanks at google.com> wrote: >> >> Should ConstantProp.cpp also be removed? It doesn't look like it's been worked on in over 10 years, and aside from check-llvm lit tests, the only use is in llvm/unittests/ExecutionEngine/MCJIT/MCJITAPITest.cpp via LLVMAddConstantPropagationPass. >> (it hasn't been ported to the new pass manager which is why I'm asking) > > > If it’s unused/not maintained I think we should also remove it or move it to the examples directory with some additional material, if it is intended to illustrate a simple pass. > > Cheers, > Florian > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200730/13387c7c/attachment.html>