Jon Roelofs via llvm-dev
2020-Apr-09 16:45 UTC
[llvm-dev] Delete Phabricator metadata tags before committing
On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote:> I was always assuming that the suggested commit is assembled in the > PHP code run by arcanist command run locally. If indeed the arc > command requests the commit message from the server,I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed: https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757> we could do some > additional things: > > * Remove "Summary:" in front of message > * Line break after 72 columns > * Convert summary markdown formatting to plain texts (e.g. remove > backticks; I don't know any git client that renders as markdown) > * Add/check existence of [component] tag > > Alternatively, we could make an upstream feature request >>From what I can tell, upstream doesn't seem /that/ interested in it beingany more than a one-off thing: https://secure.phabricator.com/Q268 https://secure.phabricator.com/T12276 https://secure.phabricator.com/T11864 Jon> Michael > > Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev > <llvm-dev at lists.llvm.org>: > > > > Can we fix this in reviews.llvm.org's fork of phab? > > > > > https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php > > > > Seems straightforward(-ish) to drop the relevant fields there, that way > `arc land` automatically DTRT. > > > > Jon >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200409/23b8e721/attachment.html>
Mehdi AMINI via llvm-dev
2020-Jul-28 05:25 UTC
[llvm-dev] Delete Phabricator metadata tags before committing
On Thu, Apr 9, 2020 at 9:45 AM Jon Roelofs <jroelofs at gmail.com> wrote:> > > On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> > wrote: > >> I was always assuming that the suggested commit is assembled in the >> PHP code run by arcanist command run locally. If indeed the arc >> command requests the commit message from the server, > > > I assumed so too until I went digging for it. Seems the client-side stuff > only deals with the structured data, and calls out to the server to > construct the raw text when needed: > > > https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757 >FYI: I patched our Phab instance and now `arc land` will omit "Subscribers", "Reviewers", and "Tags". It'll also print the description without prefixing with "Summary:". -- Mehdi> > > >> we could do some >> additional things: >> >> * Remove "Summary:" in front of message >> * Line break after 72 columns >> * Convert summary markdown formatting to plain texts (e.g. remove >> backticks; I don't know any git client that renders as markdown) >> * Add/check existence of [component] tag >> >> Alternatively, we could make an upstream feature request >> > > From what I can tell, upstream doesn't seem /that/ interested in it being > any more than a one-off thing: > > https://secure.phabricator.com/Q268 > https://secure.phabricator.com/T12276 > https://secure.phabricator.com/T11864 > > Jon > > >> Michael >> >> Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev >> <llvm-dev at lists.llvm.org>: >> > >> > Can we fix this in reviews.llvm.org's fork of phab? >> > >> > >> https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php >> > >> > Seems straightforward(-ish) to drop the relevant fields there, that way >> `arc land` automatically DTRT. >> > >> > Jon >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200727/cfc5e7e0/attachment.html>
Fāng-ruì Sòng via llvm-dev
2020-Jul-28 06:28 UTC
[llvm-dev] Delete Phabricator metadata tags before committing
On Mon, Jul 27, 2020 at 10:26 PM Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > > > On Thu, Apr 9, 2020 at 9:45 AM Jon Roelofs <jroelofs at gmail.com> wrote: >> >> >> >> On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote: >>> >>> I was always assuming that the suggested commit is assembled in the >>> PHP code run by arcanist command run locally. If indeed the arc >>> command requests the commit message from the server, >> >> >> I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed: >> >> https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757 > > > > FYI: I patched our Phab instance and now `arc land` will omit "Subscribers", "Reviewers", and "Tags". > It'll also print the description without prefixing with "Summary:". > > -- > MehdiAwesome!> >> >> >> >>> >>> we could do some >>> additional things: >>> >>> * Remove "Summary:" in front of message >>> * Line break after 72 columns >>> * Convert summary markdown formatting to plain texts (e.g. remove >>> backticks; I don't know any git client that renders as markdown) >>> * Add/check existence of [component] tag >>> >>> Alternatively, we could make an upstream feature request >> >> >> From what I can tell, upstream doesn't seem /that/ interested in it being any more than a one-off thing: >> >> https://secure.phabricator.com/Q268 >> https://secure.phabricator.com/T12276 >> https://secure.phabricator.com/T11864 >> >> Jon >> >>> >>> Michael >>> >>> Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev >>> <llvm-dev at lists.llvm.org>: >>> > >>> > Can we fix this in reviews.llvm.org's fork of phab? >>> > >>> > https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php >>> > >>> > Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT. >>> > >>> > Jon > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-- 宋方睿
Jay Foad via llvm-dev
2020-Aug-07 15:32 UTC
[llvm-dev] Delete Phabricator metadata tags before committing
I have just noticed this happening. Thank you, thank you, thank you! Jay. On Tue, 28 Jul 2020 at 06:25, Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > > > On Thu, Apr 9, 2020 at 9:45 AM Jon Roelofs <jroelofs at gmail.com> wrote: >> >> >> >> On Thu, Apr 9, 2020 at 10:29 AM Michael Kruse <llvmdev at meinersbur.de> wrote: >>> >>> I was always assuming that the suggested commit is assembled in the >>> PHP code run by arcanist command run locally. If indeed the arc >>> command requests the commit message from the server, >> >> >> I assumed so too until I went digging for it. Seems the client-side stuff only deals with the structured data, and calls out to the server to construct the raw text when needed: >> >> https://github.com/phacility/arcanist/blob/33b9728b5f65fd747b7a15c0e25436c63e82f592/src/workflow/ArcanistDiffWorkflow.php#L757 > > > > FYI: I patched our Phab instance and now `arc land` will omit "Subscribers", "Reviewers", and "Tags". > It'll also print the description without prefixing with "Summary:". > > -- > Mehdi > > >> >> >> >>> >>> we could do some >>> additional things: >>> >>> * Remove "Summary:" in front of message >>> * Line break after 72 columns >>> * Convert summary markdown formatting to plain texts (e.g. remove >>> backticks; I don't know any git client that renders as markdown) >>> * Add/check existence of [component] tag >>> >>> Alternatively, we could make an upstream feature request >> >> >> From what I can tell, upstream doesn't seem /that/ interested in it being any more than a one-off thing: >> >> https://secure.phabricator.com/Q268 >> https://secure.phabricator.com/T12276 >> https://secure.phabricator.com/T11864 >> >> Jon >> >>> >>> Michael >>> >>> Am Do., 9. Apr. 2020 um 11:16 Uhr schrieb Jon Roelofs via llvm-dev >>> <llvm-dev at lists.llvm.org>: >>> > >>> > Can we fix this in reviews.llvm.org's fork of phab? >>> > >>> > https://github.com/phacility/phabricator/blob/cac3dc4983c3671ba4ec841aac8efac10744a80c/src/applications/differential/conduit/DifferentialGetCommitMessageConduitAPIMethod.php >>> > >>> > Seems straightforward(-ish) to drop the relevant fields there, that way `arc land` automatically DTRT. >>> > >>> > Jon > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev