Christian Kandeler via llvm-dev
2020-Jun-24 09:29 UTC
[llvm-dev] Getting a patch in without commit access
Hi, I'm having trouble getting an approved patch (https://reviews.llvm.org/D80279) into the code base. The documentation (http://llvm.org/docs/Phabricator.html#committing-a-change) says: "If you do not have commit access, someone has to commit the change for you (with attribution). It is sufficient to add a comment to the approved review indicating you cannot commit the patch yourself." However, nothing has been happening for a month now. Is there anything further I can do? Just adding tons of random people in the hopes that one of them will do it seems a bit spammy... Thanks, Christian
Florian Hahn via llvm-dev
2020-Jun-24 11:04 UTC
[llvm-dev] Getting a patch in without commit access
Hi,> On Jun 24, 2020, at 10:29, Christian Kandeler via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Hi, > > I'm having trouble getting an approved patch > (https://reviews.llvm.org/D80279) into the code base. The documentation > (http://llvm.org/docs/Phabricator.html#committing-a-change) says: > "If you do not have commit access, someone has to commit > the change for you (with attribution). It is sufficient > to add a comment to the approved review indicating you > cannot commit the patch yourself." > However, nothing has been happening for a month now. Is there anything further I can do? Just adding tons of random people in the hopes that one of them will do it seems a bit spammy… >It looks like this unfortunately got missed, which can happen from time to time due to various reasons. Sorry about that! Given the patch is approved and applies cleanly, I went ahead and committed it on your behalf: 72131423cc952ccbd6d8e021ff7c04fa22297fe3 Cheers, Florian