Michael Kruse via llvm-dev
2020-Jun-10 23:49 UTC
[llvm-dev] [flang-dev] [RFC] Refactor Clang: move frontend/driver/diagnostics code to LLVM
Am Mi., 10. Juni 2020 um 10:04 Uhr schrieb Doerfert, Johannes via flang-dev <flang-dev at lists.llvm.org>:> I'm not against a subproject *but* if we also move the existing > llvm/lib/Frontend stuff, that would introduce a dependence from > llvm-core to this project, which I think is uncommon. We could also have > both. At the end of the day it depends on the benefit we would get from > an independent subproject.If we have non-conditional dependencies llvm-core->frontend-support and frontend-support->llvm-core, what advantage is there left of making frontend-support a subproject? Both of them are required all the time. Michael
Andrzej Warzynski via llvm-dev
2020-Jun-11 08:32 UTC
[llvm-dev] [flang-dev] [RFC] Refactor Clang: move frontend/driver/diagnostics code to LLVM
On 11/06/2020 00:49, Michael Kruse wrote:> Am Mi., 10. Juni 2020 um 10:04 Uhr schrieb Doerfert, Johannes via > flang-dev <flang-dev at lists.llvm.org>: >> I'm not against a subproject *but* if we also move the existing >> llvm/lib/Frontend stuff, that would introduce a dependence from >> llvm-core to this project, which I think is uncommon. We could also have >> both. At the end of the day it depends on the benefit we would get from >> an independent subproject. > > If we have non-conditional dependencies llvm-core->frontend-support > and frontend-support->llvm-core, what advantage is there left of > making frontend-support a subproject? Both of them are required all > the time. > > Michael >Thanks for the feedback! It sounds like we should keep llvm/lib/Frontend in LLVM and `frontend-support` would be a new subproject for things unrelated to LLVM IR. -Andrzej
Doerfert, Johannes via llvm-dev
2020-Jun-11 14:28 UTC
[llvm-dev] [flang-dev] [RFC] Refactor Clang: move frontend/driver/diagnostics code to LLVM
On 6/11/20 3:32 AM, Andrzej Warzynski wrote:> > > On 11/06/2020 00:49, Michael Kruse wrote: >> Am Mi., 10. Juni 2020 um 10:04 Uhr schrieb Doerfert, Johannes via >> flang-dev <flang-dev at lists.llvm.org>: >>> I'm not against a subproject *but* if we also move the existing >>> llvm/lib/Frontend stuff, that would introduce a dependence from >>> llvm-core to this project, which I think is uncommon. We could also >>> have >>> both. At the end of the day it depends on the benefit we would get from >>> an independent subproject. >> >> If we have non-conditional dependencies llvm-core->frontend-support >> and frontend-support->llvm-core, what advantage is there left of >> making frontend-support a subproject? Both of them are required all >> the time. >> >> Michael >> > > Thanks for the feedback! It sounds like we should keep > llvm/lib/Frontend in LLVM and `frontend-support` would be a new > subproject for things unrelated to LLVM IR.Sure, if we expect usage of such a subproject without llvm-core. (Maybe there are other reasons to separate it but I'm not sure I understood them.) Thanks, Johannes> > -Andrzej