llvm dev - Jun 2020 - Aarch64: unaligned access despite -mstrict-align

Sorry, quick message to ignore what I wrote before, I got myself confused
(probably you too),
With a recent trunk build I get this:

f:
        adrp    x8, g
        ldr     x8, [x8, :lo12:g]
        mov     w2, #16
        mov     x1, x0
        mov     x0, x8
        b       memcmp

This looks more correct, and I need to look a bit more into this (and how clang
10.0.0 behaves).


________________________________
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Sjoerd
Meijer via llvm-dev <llvm-dev at lists.llvm.org>
Sent: 01 June 2020 16:32
To: llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>; Jerome
Forissier <jerome at forissier.org>
Cc: op-tee at lists.trustedfirmware.org <op-tee at
lists.trustedfirmware.org>
Subject: Re: [llvm-dev] Aarch64: unaligned access despite -mstrict-align

Hi Jerome,
> Note the 'ldr x9, [x0]'. At this point there is no guarantee that
x0 is a multiple of 8, so why is Clang generating this code?
I think the point is that it can assume it is 8 byte aligned, so the question is
why it isn't.  I guess that requires looking into how memory is allocated to
what C is pointing to, or if some type punning caused passing an address that is
not properly aligned.

Cheers,
Sjoerd.
________________________________
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Jerome
Forissier via llvm-dev <llvm-dev at lists.llvm.org>
Sent: 01 June 2020 15:26
To: llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org>
Cc: op-tee at lists.trustedfirmware.org <op-tee at
lists.trustedfirmware.org>
Subject: [llvm-dev] Aarch64: unaligned access despite -mstrict-align

Hi,

I experienced a crash in code compiled with Clang 10.0.0 due to a
misaligned 64-bit data access. The (ARMv8) CPU is configured with SCTL.A
== 1 (alignment check enable). With SCTLR.A == 0 the code runs as expected.

After some investigation I came up with the following reproducer:

---8<-------8<-------8<-------8<-------8<-------8<-------8<-------
$ cat test.c
extern char *g;
int memcmp(const void *s1, const void *s2, unsigned long n);

int f(void *c)
{
        return memcmp(g, c, 16);
}
$ clang --target=aarch64-linux-gnu -Os -mstrict-align -S test.c
$ cat test.s
        .text
        .file   "test.c"
        .globl  f                       // -- Begin function f
        .p2align        2
        .type   f, at function
f:                                      // @f
// %bb.0:
        adrp    x8, g
        ldr     x10, [x8, :lo12:g]
        ldr     x9, [x0]
        ldr     x8, [x10]
        rev     x9, x9
        rev     x8, x8
        cmp     x8, x9
        b.ne    .LBB0_3
// %bb.1:
        ldr     x8, [x10, #8]
        ldr     x9, [x0, #8]
        rev     x8, x8
        rev     x9, x9
        cmp     x8, x9
        b.ne    .LBB0_3
// %bb.2:
        mov     w0, wzr
        ret
.LBB0_3:
        cmp     x8, x9
        mov     w8, #-1
        cneg    w0, w8, hs
        ret
.Lfunc_end0:
        .size   f, .Lfunc_end0-f
                                        // -- End function
        .ident  "clang version 10.0.0-4ubuntu1 "
        .section        ".note.GNU-stack","", at progbits
        .addrsig
---8<-------8<-------8<-------8<-------8<-------8<-------8<-------

Note the 'ldr x9, [x0]'. At this point there is no guarantee that x0 is
a multiple of 8, so why is Clang generating this code?

Thanks,
--
Jerome
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200601/83a4ef2a/attachment.html>

On 6/1/20 6:26 PM, Sjoerd Meijer wrote:
> Sorry, quick message to ignore what I wrote before, I got myself confused
(probably you too),
:)
> With a recent trunk build I get this:
> 
> f:
>         adrp    x8, g
>         ldr     x8, [x8, :lo12:g]
>         mov     w2, #16
>         mov     x1, x0
>         mov     x0, x8
>         b       memcmp
> 
> This looks more correct, and I need to look a bit more into this (and how
clang 10.0.0 behaves).
Indeed I would be quite happy with that ;-) Good to know that master
generated this. If you would you like me to bisect and identify the
commit that changed the behavior, please let me know.

Thanks,
-- 
Jerome

See https://reviews.llvm.org/D76113 and my followup
https://reviews.llvm.org/D77599 .  (I didn't really think about it at the
time, but maybe worth nominating for 10.0.1.)

-Eli

-----Original Message-----
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Jerome
Forissier via llvm-dev
Sent: Monday, June 1, 2020 9:52 AM
To: Sjoerd Meijer <Sjoerd.Meijer at arm.com>; llvm-dev at lists.llvm.org
Cc: op-tee at lists.trustedfirmware.org
Subject: [EXT] Re: [llvm-dev] Aarch64: unaligned access despite -mstrict-align

On 6/1/20 6:26 PM, Sjoerd Meijer wrote:
> Sorry, quick message to ignore what I wrote before, I got myself confused
(probably you too),
:)
> With a recent trunk build I get this:
>
> f:
>         adrp    x8, g
>         ldr     x8, [x8, :lo12:g]
>         mov     w2, #16
>         mov     x1, x0
>         mov     x0, x8
>         b       memcmp
>
> This looks more correct, and I need to look a bit more into this (and how
clang 10.0.0 behaves).
Indeed I would be quite happy with that ;-) Good to know that master
generated this. If you would you like me to bisect and identify the
commit that changed the behavior, please let me know.

Thanks,
--
Jerome
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev