James Henderson via llvm-dev
2020-Apr-28 07:34 UTC
[llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging
Hi Scott, It's possible they've missed it, so I've explicitly CC'ed a number of the usual DWARF suspects, at least some of whom are on the standards committee. I don't have anything specific to add myself. James On Mon, 27 Apr 2020 at 15:25, via llvm-dev <llvm-dev at lists.llvm.org> wrote:> I don't know what an acceptable ping rate on an RFC is, but I also > wanted to add that if anyone prefers to review this on Phabricator the > latest diff of https://reviews.llvm.org/D70523 essentially includes the > entire contents of the proposal, because it was moved to another file. > > Thanks, > Scott > > On 2020-04-17 19:10, Scott Linder via llvm-dev wrote: > > Hi llvm-dev, > > > > I'm writing on behalf of a team at AMD working on upstreaming support > > for AMD GPUs into GDB. We have drafted a proposal of backwards > > compatible extensions to DWARF for heterogeneous debugging which is > > rendered at > > https://llvm.org/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.html. > > > > The proposal includes a thorough introduction with justification, so I > > won't belabor that here, but I do want to reiterate that the extensions > > are designed to be vendor and architecture neutral, and completely > > backwards compatible with DWARF 5. > > > > I am beginning to work on a reference implementation of the proposal in > > LLVM, with some very preliminary support appearing in some patches > > starting at https://reviews.llvm.org/D76877. Note that most of these > > initial patches are AMDGPU-specific CFI changes, and more general > > support for the extensions are still a WIP. > > > > I intended to also include the proposal inline, but it appears to be > > too > > large for the list. Instead I will just mention that the source is > > available in the llvm-project repo as > > llvm/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.rst > > > > Regards, > > Scott > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200428/b802c9b9/attachment.html>
Robinson, Paul via llvm-dev
2020-Apr-28 14:40 UTC
[llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging
Been meaning to get to this… I have to say, it’s a big lump of text to take in. Two general questions: Did you still want comments posted on the review (D70523) or in some other fashion? And, would it be possible to more clearly identify the new/changed bits of the sections that you are quoting from the spec? When I see a bunch of familiar text I’m inclined to skim over it, which means I’m likely to miss something that just has that subtle “New” on it. Maybe you could put a Note at those points just to be a more obvious call-out. Thanks, --paulr From: James Henderson <jh7370.2008 at my.bristol.ac.uk> Sent: Tuesday, April 28, 2020 3:34 AM To: scott at scottlinder.com Cc: llvm-dev <llvm-dev at lists.llvm.org>; Robinson, Paul <paul.robinson at sony.com>; David Blaikie <dblaikie at gmail.com>; Adrian Prantl <aprantl at apple.com>; Jonas Devlieghere <jdevlieghere at apple.com>; Igor Kudrin <ikudrin at accesssoftek.com> Subject: Re: [llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging Hi Scott, It's possible they've missed it, so I've explicitly CC'ed a number of the usual DWARF suspects, at least some of whom are on the standards committee. I don't have anything specific to add myself. James On Mon, 27 Apr 2020 at 15:25, via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: I don't know what an acceptable ping rate on an RFC is, but I also wanted to add that if anyone prefers to review this on Phabricator the latest diff of https://reviews.llvm.org/D70523<https://urldefense.com/v3/__https:/reviews.llvm.org/D70523__;!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI8JC_ekBA$> essentially includes the entire contents of the proposal, because it was moved to another file. Thanks, Scott On 2020-04-17 19:10, Scott Linder via llvm-dev wrote:> Hi llvm-dev, > > I'm writing on behalf of a team at AMD working on upstreaming support > for AMD GPUs into GDB. We have drafted a proposal of backwards > compatible extensions to DWARF for heterogeneous debugging which is > rendered at > https://llvm.org/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.html<https://urldefense.com/v3/__https:/llvm.org/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.html__;!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jIuimFA$>. > > The proposal includes a thorough introduction with justification, so I > won't belabor that here, but I do want to reiterate that the extensions > are designed to be vendor and architecture neutral, and completely > backwards compatible with DWARF 5. > > I am beginning to work on a reference implementation of the proposal in > LLVM, with some very preliminary support appearing in some patches > starting at https://reviews.llvm.org/D76877<https://urldefense.com/v3/__https:/reviews.llvm.org/D76877__;!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI-GI5zmzA$>. Note that most of these > initial patches are AMDGPU-specific CFI changes, and more general > support for the extensions are still a WIP. > > I intended to also include the proposal inline, but it appears to be > too > large for the list. Instead I will just mention that the source is > available in the llvm-project repo as > llvm/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.rst > > Regards, > Scott > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jFtexOA$>_______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jFtexOA$> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200428/f515ab1d/attachment.html>
Tye, Tony via llvm-dev
2020-Apr-30 01:02 UTC
[llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging
[AMD Public Use] Hi Paul, Almost all the text in the proposal is different to some extent to what is in the DWARF 5 spec. Some passages are clearly brought forward from the DWARF 5 spec, but generally needed changing to some extent to fit in with the new text. I did add "Notes" to tie each section back to the DWARF 5 spec that it modifies. Since the proposal is largely concerned with DWARF location descriptions and addresses it ended up touching a lot of places in the DWARF expression sections and the attributes that use them. Despite the size of the proposed changes, the intent is that it is fully backward compatible with DWARF 5. Making comments in the review would likely be the easiest to track. Thanks, -Tony From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Robinson, Paul via llvm-dev Sent: Tuesday, April 28, 2020 10:40 AM To: jh7370.2008 at my.bristol.ac.uk; scott at scottlinder.com Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging [CAUTION: External Email] Been meaning to get to this... I have to say, it's a big lump of text to take in. Two general questions: Did you still want comments posted on the review (D70523) or in some other fashion? And, would it be possible to more clearly identify the new/changed bits of the sections that you are quoting from the spec? When I see a bunch of familiar text I'm inclined to skim over it, which means I'm likely to miss something that just has that subtle "New" on it. Maybe you could put a Note at those points just to be a more obvious call-out. Thanks, --paulr From: James Henderson <jh7370.2008 at my.bristol.ac.uk<mailto:jh7370.2008 at my.bristol.ac.uk>> Sent: Tuesday, April 28, 2020 3:34 AM To: scott at scottlinder.com<mailto:scott at scottlinder.com> Cc: llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>>; Robinson, Paul <paul.robinson at sony.com<mailto:paul.robinson at sony.com>>; David Blaikie <dblaikie at gmail.com<mailto:dblaikie at gmail.com>>; Adrian Prantl <aprantl at apple.com<mailto:aprantl at apple.com>>; Jonas Devlieghere <jdevlieghere at apple.com<mailto:jdevlieghere at apple.com>>; Igor Kudrin <ikudrin at accesssoftek.com<mailto:ikudrin at accesssoftek.com>> Subject: Re: [llvm-dev] [RFC] DWARF Version 6 Proposal For Heterogeneous Debugging Hi Scott, It's possible they've missed it, so I've explicitly CC'ed a number of the usual DWARF suspects, at least some of whom are on the standards committee. I don't have anything specific to add myself. James On Mon, 27 Apr 2020 at 15:25, via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: I don't know what an acceptable ping rate on an RFC is, but I also wanted to add that if anyone prefers to review this on Phabricator the latest diff of https://reviews.llvm.org/D70523<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2Freviews.llvm.org%2FD70523__%3B!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI8JC_ekBA%24&data=02%7C01%7Ctony.tye%40amd.com%7C573f5e4eb8044a93728e08d7eb82185a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236816295633562&sdata=Xea3dSFq2f%2BeYWgU0MgStVKpS40Gma2EUuhoFoMrFYk%3D&reserved=0> essentially includes the entire contents of the proposal, because it was moved to another file. Thanks, Scott On 2020-04-17 19:10, Scott Linder via llvm-dev wrote:> Hi llvm-dev, > > I'm writing on behalf of a team at AMD working on upstreaming support > for AMD GPUs into GDB. We have drafted a proposal of backwards > compatible extensions to DWARF for heterogeneous debugging which is > rendered at > https://llvm.org/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.html<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2Fllvm.org%2Fdocs%2FAMDGPUDwarfProposalForHeterogeneousDebugging.html__%3B!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jIuimFA%24&data=02%7C01%7Ctony.tye%40amd.com%7C573f5e4eb8044a93728e08d7eb82185a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236816295633562&sdata=v7aYdGa%2BWFPU%2B5DXfjEF4L6quyz7Gmm46tjYIQrFdSU%3D&reserved=0>. > > The proposal includes a thorough introduction with justification, so I > won't belabor that here, but I do want to reiterate that the extensions > are designed to be vendor and architecture neutral, and completely > backwards compatible with DWARF 5. > > I am beginning to work on a reference implementation of the proposal in > LLVM, with some very preliminary support appearing in some patches > starting at https://reviews.llvm.org/D76877<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2Freviews.llvm.org%2FD76877__%3B!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI-GI5zmzA%24&data=02%7C01%7Ctony.tye%40amd.com%7C573f5e4eb8044a93728e08d7eb82185a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236816295643518&sdata=LjRVy7nvATi%2BwWm6vqNf5NB%2FALTcvl0PdA2rgUDPnqA%3D&reserved=0>. Note that most of these > initial patches are AMDGPU-specific CFI changes, and more general > support for the extensions are still a WIP. > > I intended to also include the proposal inline, but it appears to be > too > large for the list. Instead I will just mention that the source is > available in the llvm-project repo as > llvm/docs/AMDGPUDwarfProposalForHeterogeneousDebugging.rst > > Regards, > Scott > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-dev__%3B!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jFtexOA%24&data=02%7C01%7Ctony.tye%40amd.com%7C573f5e4eb8044a93728e08d7eb82185a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236816295643518&sdata=Db9cVEy1PrFny%2F7pvj5fydkyO3sNfOzvZ7kyRREngJE%3D&reserved=0>_______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.com%2Fv3%2F__https%3A%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-dev__%3B!!JmoZiZGBv3RvKRSx!tpmHtMZselmOKP-gUwNy5yEJqQ_f_dbyWAOGEyGoz6JRi6wyQbvO6D26MI9jFtexOA%24&data=02%7C01%7Ctony.tye%40amd.com%7C573f5e4eb8044a93728e08d7eb82185a%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637236816295653470&sdata=8zAiw%2BnKM55xbNFsfZTzHp9aZSJxVIWRG5AZq4N4UeY%3D&reserved=0> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200430/d580b92f/attachment.html>