Stefanos Baziotis via llvm-dev
2020-Mar-01 16:25 UTC
[llvm-dev] Commits as new contributor
Hi Hal,> Documentation updates should also be reviewed.Of course, I meant that I'll open a patch in Phabricator. :) I didn't know about code-review patch, thanks. I'll defer the update of developer policy until the other patch is committed so we can have a clearer picture. Kind regards, Stefanos Στις Κυρ, 1 Μαρ 2020 στις 6:17 μ.μ., ο/η Finkel, Hal J. <hfinkel at anl.gov> έγραψε:> Hi, Stefanos, > > Documentation updates should also be reviewed. In this case, I think that > it makes the most sense to reference our new code-review documentation that > should be committed soon (https://reviews.llvm.org/D71916). It might > actually be best to remove some of that developer-policy text and simply > reference the new code-review documentation in order to prevent confusion. > > Thanks, > Hal > > Hal Finkel > Lead, Compiler Technology and Programming Languages > Leadership Computing Facility > Argonne National Laboratory > > ------------------------------ > *From:* llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Stefanos > Baziotis via llvm-dev <llvm-dev at lists.llvm.org> > *Sent:* Sunday, March 1, 2020 9:58 AM > *To:* Florian Hahn <florian_hahn at apple.com> > *Cc:* llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org> > *Subject:* Re: [llvm-dev] Commits as new contributor > > Thanks to both! I'll update the docs. > > Best, > Stefanos > > Στις Κυρ, 1 Μαρ 2020 στις 5:24 μ.μ., ο/η Florian Hahn < > florian_hahn at apple.com> έγραψε: > > Hi, > > > On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > I recently was granted commit access, but I'm not really sure what is the > process. > The developer policy states: > "You are granted *commit-after-approval* to all parts of LLVM. To get > approval, submit a patch > <https://llvm.org/docs/DeveloperPolicy.html#patch> to llvm-commits > <http://lists.llvm.org/mailman/listinfo/llvm-commits>. When approved, you > may commit it yourself." > > Do I have to send the patch to llvm-commits via email and wait for > approval even when the patch has been accepted in the reviews (i.e. > Phabricator) ? > > > > Approval via Phabricator is fine. LLVM-commits (or the relevant sub > project list) should always be a subscriber of reviews in Phabricator, so > the approval is recorded there too. > > It may be worth updating the wording in the docs to explicitly mention > Phabricator. > > Cheers > Florian > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/16b2fdea/attachment.html>
Great, and thanks for bringing this up! -Hal Hal Finkel Lead, Compiler Technology and Programming Languages Leadership Computing Facility Argonne National Laboratory ________________________________ From: Stefanos Baziotis <stefanos.baziotis at gmail.com> Sent: Sunday, March 1, 2020 10:25 AM To: Finkel, Hal J. <hfinkel at anl.gov> Cc: Florian Hahn <florian_hahn at apple.com>; llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] Commits as new contributor Hi Hal,> Documentation updates should also be reviewed.Of course, I meant that I'll open a patch in Phabricator. :) I didn't know about code-review patch, thanks. I'll defer the update of developer policy until the other patch is committed so we can have a clearer picture. Kind regards, Stefanos Στις Κυρ, 1 Μαρ 2020 στις 6:17 μ.μ., ο/η Finkel, Hal J. <hfinkel at anl.gov<mailto:hfinkel at anl.gov>> έγραψε: Hi, Stefanos, Documentation updates should also be reviewed. In this case, I think that it makes the most sense to reference our new code-review documentation that should be committed soon (https://reviews.llvm.org/D71916). It might actually be best to remove some of that developer-policy text and simply reference the new code-review documentation in order to prevent confusion. Thanks, Hal Hal Finkel Lead, Compiler Technology and Programming Languages Leadership Computing Facility Argonne National Laboratory ________________________________ From: llvm-dev <llvm-dev-bounces at lists.llvm.org<mailto:llvm-dev-bounces at lists.llvm.org>> on behalf of Stefanos Baziotis via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> Sent: Sunday, March 1, 2020 9:58 AM To: Florian Hahn <florian_hahn at apple.com<mailto:florian_hahn at apple.com>> Cc: llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org> <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> Subject: Re: [llvm-dev] Commits as new contributor Thanks to both! I'll update the docs. Best, Stefanos Στις Κυρ, 1 Μαρ 2020 στις 5:24 μ.μ., ο/η Florian Hahn <florian_hahn at apple.com<mailto:florian_hahn at apple.com>> έγραψε: Hi, On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: I recently was granted commit access, but I'm not really sure what is the process. The developer policy states: "You are granted commit-after-approval to all parts of LLVM. To get approval, submit a patch<https://llvm.org/docs/DeveloperPolicy.html#patch> to llvm-commits<http://lists.llvm.org/mailman/listinfo/llvm-commits>. When approved, you may commit it yourself." Do I have to send the patch to llvm-commits via email and wait for approval even when the patch has been accepted in the reviews (i.e. Phabricator) ? Approval via Phabricator is fine. LLVM-commits (or the relevant sub project list) should always be a subscriber of reviews in Phabricator, so the approval is recorded there too. It may be worth updating the wording in the docs to explicitly mention Phabricator. Cheers Florian -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/b02c8481/attachment.html>
Stefanos Baziotis via llvm-dev
2020-Mar-01 16:56 UTC
[llvm-dev] Commits as new contributor
My pleasure, thanks for the help! Best, Stefanos Στις Κυρ, 1 Μαρ 2020 στις 6:44 μ.μ., ο/η Finkel, Hal J. <hfinkel at anl.gov> έγραψε:> Great, and thanks for bringing this up! > > -Hal > > Hal Finkel > Lead, Compiler Technology and Programming Languages > Leadership Computing Facility > Argonne National Laboratory > > ------------------------------ > *From:* Stefanos Baziotis <stefanos.baziotis at gmail.com> > *Sent:* Sunday, March 1, 2020 10:25 AM > *To:* Finkel, Hal J. <hfinkel at anl.gov> > *Cc:* Florian Hahn <florian_hahn at apple.com>; llvm-dev at lists.llvm.org < > llvm-dev at lists.llvm.org> > *Subject:* Re: [llvm-dev] Commits as new contributor > > Hi Hal, > > > Documentation updates should also be reviewed. > Of course, I meant that I'll open a patch in Phabricator. :) > > I didn't know about code-review patch, thanks. I'll defer the update of > developer policy until the other patch is committed so we can have a > clearer picture. > > Kind regards, > Stefanos > > Στις Κυρ, 1 Μαρ 2020 στις 6:17 μ.μ., ο/η Finkel, Hal J. <hfinkel at anl.gov> > έγραψε: > > Hi, Stefanos, > > Documentation updates should also be reviewed. In this case, I think that > it makes the most sense to reference our new code-review documentation that > should be committed soon (https://reviews.llvm.org/D71916). It might > actually be best to remove some of that developer-policy text and simply > reference the new code-review documentation in order to prevent confusion. > > Thanks, > Hal > > Hal Finkel > Lead, Compiler Technology and Programming Languages > Leadership Computing Facility > Argonne National Laboratory > > ------------------------------ > *From:* llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Stefanos > Baziotis via llvm-dev <llvm-dev at lists.llvm.org> > *Sent:* Sunday, March 1, 2020 9:58 AM > *To:* Florian Hahn <florian_hahn at apple.com> > *Cc:* llvm-dev at lists.llvm.org <llvm-dev at lists.llvm.org> > *Subject:* Re: [llvm-dev] Commits as new contributor > > Thanks to both! I'll update the docs. > > Best, > Stefanos > > Στις Κυρ, 1 Μαρ 2020 στις 5:24 μ.μ., ο/η Florian Hahn < > florian_hahn at apple.com> έγραψε: > > Hi, > > > On 1 Mar 2020, at 14:44, Stefanos Baziotis via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > I recently was granted commit access, but I'm not really sure what is the > process. > The developer policy states: > "You are granted *commit-after-approval* to all parts of LLVM. To get > approval, submit a patch > <https://llvm.org/docs/DeveloperPolicy.html#patch> to llvm-commits > <http://lists.llvm.org/mailman/listinfo/llvm-commits>. When approved, you > may commit it yourself." > > Do I have to send the patch to llvm-commits via email and wait for > approval even when the patch has been accepted in the reviews (i.e. > Phabricator) ? > > > > Approval via Phabricator is fine. LLVM-commits (or the relevant sub > project list) should always be a subscriber of reviews in Phabricator, so > the approval is recorded there too. > > It may be worth updating the wording in the docs to explicitly mention > Phabricator. > > Cheers > Florian > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200301/4f057020/attachment.html>