Jinsong Ji via llvm-dev
2020-Jan-28 19:04 UTC
[llvm-dev] [RFC] Print FP constant assembly in hexadecimal form instead of decimal
Hi: When debugging some floating point assembly, we found it is inconvenient to read the decimal constants in assembly. In hex form many FP numbers are immediately recognizable, their exponents are more obvious etc. We normally use hex form in debugger or LLVM IR, not sure what is the reason that we want to use decimal in assembly? The form change won't change precision or affecting rounding, I think most assembler should support hex form too? Appreciate your feedback and comments if there is anything that we should consider before changing the default behavior. FYI. This is a patch https://reviews.llvm.org/D73566 that show the change and affected in tree testcases. Reviews and comments are highly appreciated, thank you! Best, Jinsong Ji (纪金松), PhD. XL/LLVM on Power Compiler Development E-mail: jji at us.ibm.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200128/31a7c115/attachment.html>
Jacob Lifshay via llvm-dev
2020-Jan-28 21:32 UTC
[llvm-dev] [RFC] Print FP constant assembly in hexadecimal form instead of decimal
On Tue, Jan 28, 2020 at 11:05 AM Jinsong Ji via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > Hi: > > When debugging some floating point assembly, we found it is inconvenient to read the decimal constants in assembly. > > In hex form many FP numbers are immediately recognizable, their exponents are more obvious etc. > We normally use hex form in debugger or LLVM IR, > not sure what is the reason that we want to use decimal in assembly?This seems like a really good idea! Jacob
Nemanja Ivanovic via llvm-dev
2020-Feb-04 13:51 UTC
[llvm-dev] [RFC] Print FP constant assembly in hexadecimal form instead of decimal
Seems reasonable to me, but we should make sure that various assemblers out there support this. I think it would make sense to try this out on some number of platforms before proceeding. Perhaps a few Linux distros, AIX, Windows, MacOS, FreeBSD. And of course, to make sure that LLVM's own llvm-mc understands it :) (but I suspect this is in the mentioned patch which I haven't looked at yet). On Tue, Jan 28, 2020 at 4:33 PM Jacob Lifshay via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On Tue, Jan 28, 2020 at 11:05 AM Jinsong Ji via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > > > Hi: > > > > When debugging some floating point assembly, we found it is inconvenient > to read the decimal constants in assembly. > > > > In hex form many FP numbers are immediately recognizable, their > exponents are more obvious etc. > > We normally use hex form in debugger or LLVM IR, > > not sure what is the reason that we want to use decimal in assembly? > > This seems like a really good idea! > > Jacob > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200204/5cf6c0c7/attachment.html>