llvm dev - Jan 2020 - [cfe-dev] Phabricator -> GitHub PRs?

On 01/15, Nicolai Hähnle via cfe-dev wrote:
> On Tue, Jan 14, 2020 at 11:41 AM Renato Golin <rengolin at gmail.com>
wrote:
> > We rarely approve some patches and not others in a series, and when we
> > do, we ask people to create a new series without the approved patch,
> > or split them, so that we can continue reviewing the series.
> 
> This has simply not been true in my experience. Actually, not having
> to re-send a new series is one of the main advantages that
> Phabricator-based review has over the original review style for Git,
> which is to send patch series via mailing lists.
> 
> It might be the case that you occasionally have series where major
> redesigns are required, and then asking for a fresh start makes sense.
There is an (ever growing) patch series that connects contributions by
multiple people with patches in all sorts of states, from merged to WIP:

The first was this one https://reviews.llvm.org/D69785, since then the
series grew in all directions (see the stack).

I have other (=smaller) patch series that evolve over time but this one
is the biggest and most complex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200115/6afd0fc4/attachment.sig>

"Doerfert, Johannes via llvm-dev" <llvm-dev at lists.llvm.org>
writes:
> The first was this one https://reviews.llvm.org/D69785, since then the
> series grew in all directions (see the stack).
How do I see the stack?

This is a great example of the (to me) unintuitive interface of Phab.
People talk about things like "the stack" as if it's obvious and
it's
really not.

                        -David

On Thu, Jan 16, 2020 at 10:10 AM David Greene via cfe-dev <
cfe-dev at lists.llvm.org> wrote:
> "Doerfert, Johannes via llvm-dev" <llvm-dev at
lists.llvm.org> writes:
>
> > The first was this one https://reviews.llvm.org/D69785, since then the
> > series grew in all directions (see the stack).
>
> How do I see the stack?
>
> This is a great example of the (to me) unintuitive interface of Phab.
> People talk about things like "the stack" as if it's obvious
and it's
> really not.
>
Yeah, once something's got a lot of commenting on it - but there's two
instances of the word "stack" when I open and search that page. The
first
one is the one you're looking for I think - under "Revision
Contents"
there's "Files", "History", "Commits",
"Stack", and "Similar".

If you open "Stack" it shows various related and not so related
commits in
the timeline - if you look at the line related to this review (highlighted
in yellow) you can see that this patch is on the purple coloured stack. So
you can see patches built up on top of it, such as D69922.

If you're reviewing this patch - in the timeline of comments you'd see a
structured event description like "jdoerfert
<https://reviews.llvm.org/p/jdoerfert/> added a child revision: D69922:
[OpenMP] Use the OpenMP-IR-Builder
<https://reviews.llvm.org/D69922>."
telling you that there was a new patch added that is based on top of this
one.

>                         -David
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200116/127ad087/attachment.html>