llvm dev - Dec 2019 - Weird update_llc_test_checks behavior?

I've run update_llc_test_checks on a set of tests and am seeing some
weird behavior. The CHECK lines appear directly after the function's
first line, even if there are multiple arguments. E.g.:

define <vscale x 4 x i32> @sel_nxv4i32(<vscale x 4 x i1> %p,
; CHECK-LABEL: sel_nxv4i32:
; CHECK:       // %bb.0:
; CHECK-NEXT:    mov z0.s, p0/m, z1.s
; CHECK-NEXT:    ret
                                       <vscale x 4 x i32> %dst,
                                       <vscale x 4 x i32> %a) {

Is that the intended behavior? Or am I doing something wrong?

Thanks,
Cam

I've seen that, it doesn't actually add the check-lines after the `{`,
but after the end of the line where the function name matched.
So the fix is to make sure that function definition,
including starting `{`, is a single line.

Roman.

On Thu, Dec 12, 2019 at 1:37 AM Cameron McInally via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> I've run update_llc_test_checks on a set of tests and am seeing some
> weird behavior. The CHECK lines appear directly after the function's
> first line, even if there are multiple arguments. E.g.:
>
> define <vscale x 4 x i32> @sel_nxv4i32(<vscale x 4 x i1> %p,
> ; CHECK-LABEL: sel_nxv4i32:
> ; CHECK:       // %bb.0:
> ; CHECK-NEXT:    mov z0.s, p0/m, z1.s
> ; CHECK-NEXT:    ret
>                                        <vscale x 4 x i32> %dst,
>                                        <vscale x 4 x i32> %a) {
>
> Is that the intended behavior? Or am I doing something wrong?
>
> Thanks,
> Cam
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

I would first try to not (manually) split the function definition across
multiple lines. The update scripts are simple beasts.

________________________________________
From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of Cameron
McInally via llvm-dev <llvm-dev at lists.llvm.org>
Sent: Wednesday, December 11, 2019 16:37
To: LLVM Developers Mailing List
Subject: [llvm-dev] Weird update_llc_test_checks behavior?

I've run update_llc_test_checks on a set of tests and am seeing some
weird behavior. The CHECK lines appear directly after the function's
first line, even if there are multiple arguments. E.g.:

define <vscale x 4 x i32> @sel_nxv4i32(<vscale x 4 x i1> %p,
; CHECK-LABEL: sel_nxv4i32:
; CHECK:       // %bb.0:
; CHECK-NEXT:    mov z0.s, p0/m, z1.s
; CHECK-NEXT:    ret
                                       <vscale x 4 x i32> %dst,
                                       <vscale x 4 x i32> %a) {

Is that the intended behavior? Or am I doing something wrong?

Thanks,
Cam
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

Thanks, Roman. I guess I've never had a declaration span multiple
lines before. :/

On Wed, Dec 11, 2019 at 5:47 PM Roman Lebedev <lebedev.ri at gmail.com>
wrote:
>
> I've seen that, it doesn't actually add the check-lines after the
`{`,
> but after the end of the line where the function name matched.
> So the fix is to make sure that function definition,
> including starting `{`, is a single line.
>
> Roman.
>
> On Thu, Dec 12, 2019 at 1:37 AM Cameron McInally via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > I've run update_llc_test_checks on a set of tests and am seeing
some
> > weird behavior. The CHECK lines appear directly after the
function's
> > first line, even if there are multiple arguments. E.g.:
> >
> > define <vscale x 4 x i32> @sel_nxv4i32(<vscale x 4 x i1>
%p,
> > ; CHECK-LABEL: sel_nxv4i32:
> > ; CHECK:       // %bb.0:
> > ; CHECK-NEXT:    mov z0.s, p0/m, z1.s
> > ; CHECK-NEXT:    ret
> >                                        <vscale x 4 x i32> %dst,
> >                                        <vscale x 4 x i32> %a) {
> >
> > Is that the intended behavior? Or am I doing something wrong?
> >
> > Thanks,
> > Cam
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> >
https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=hES3KpSMbmPl4aJs326wcvuL6b1cut3wPi7GJxJ5mdM&s=ZzWCSZfkyMNzMJcDa1dLidLamD853B_oDOukKMFNtk0&e=