On Sat, Nov 2, 2019 at 4:26 AM Mehdi AMINI via llvm-dev <llvm-dev at lists.llvm.org> wrote:> On Wed, Oct 30, 2019 at 10:59 PM David Zarzycki via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> >> >> On Oct 30, 2019, at 5:57 PM, Tom Stellard via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> On 10/30/2019 03:09 AM, Stephan Bergmann via llvm-dev wrote: >> >> You can apparently leave comments on GitHub commits (instead of commenting at Phabricator, or directly sending a reply to the relevant commit mailing list and relevant CCs). I once accidentally did that myself (<https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755>) and now (presumably because I'm member of some GitHub group) got mail about <https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925>. >> >> Do we want to allow such comments? >> >> >> I think we would like this disabled, but I don't think it's possible. >> Or at least I haven't found a way to do it yet. >> >> >> Not automatically as far as I can tell. One can manually “lock the conversation” on a commit but that’s about it. >> >> From what I’ve seen on other projects, comments on raw git commits are rare and self-limiting. The only reasonable responses are “okay”, “okay, file a bug”, and “okay, please submit a patch”. I also haven’t verified this, but I suspect only the commit author gets notified, which prevents idle people from piling onto to the conversation. >> > > Watchers of the repo get the comments (just like pull-requests). > > I suspect that moving to a system where people are watching the repository instead of subscribing to the mailing-list is likely unavoidable at some point.Then again, watching the repository will ultimately be like subscribing to llvm-commits, won't it? How many people do _that_ and actually track what happens? I personally can't imagine doing that without some serious automatic filtering... Cheers, Nicolai> > -- > Mehdi > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-- Lerne, wie die Welt wirklich ist, aber vergiss niemals, wie sie sein sollte.
> >> From what I’ve seen on other projects, comments on raw git commits are > rare and self-limiting. The only reasonable responses are “okay”, “okay, > file a bug”, and “okay, please submit a patch”. I also haven’t verified > this, but I suspect only the commit author gets notified, which prevents > idle people from piling onto to the conversation. > >> > > > > Watchers of the repo get the comments (just like pull-requests). > > > > I suspect that moving to a system where people are watching the > repository instead of subscribing to the mailing-list is likely > unavoidable at some point. > > Then again, watching the repository will ultimately be like > subscribing to llvm-commits, won't it? How many people do _that_ and > actually track what happens? I personally can't imagine doing that > without some serious automatic filtering...Not sure what you mean by "actually track what happens." I subscribe, and I skim the subject lines nearly every day, to see whether anything interesting has happened. I actually *read* maybe 1 or 2 percent of the traffic. In order for automatic filtering to work, I'd need to decide ahead of time what keywords and/or people to care about. I'd rather not look at the project with such blinders in place. --paulr
On 11/4/19 8:44 AM, Robinson, Paul via llvm-dev wrote:>>>> From what I’ve seen on other projects, comments on raw git commits are >> rare and self-limiting. The only reasonable responses are “okay”, “okay, >> file a bug”, and “okay, please submit a patch”. I also haven’t verified >> this, but I suspect only the commit author gets notified, which prevents >> idle people from piling onto to the conversation. >>> Watchers of the repo get the comments (just like pull-requests). >>> >>> I suspect that moving to a system where people are watching the >> repository instead of subscribing to the mailing-list is likely >> unavoidable at some point. >> >> Then again, watching the repository will ultimately be like >> subscribing to llvm-commits, won't it? How many people do _that_ and >> actually track what happens? I personally can't imagine doing that >> without some serious automatic filtering... > Not sure what you mean by "actually track what happens." > I subscribe, and I skim the subject lines nearly every day, to see > whether anything interesting has happened. I actually *read* maybe > 1 or 2 percent of the traffic. In order for automatic filtering to > work, I'd need to decide ahead of time what keywords and/or people to > care about. I'd rather not look at the project with such blinders in > place. > --paulr+1 There are some of us who do this. To the subject of this thread: is this comment feature useful for the purpose of post-commit code review? -Hal> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-- Hal Finkel Lead, Compiler Technology and Programming Languages Leadership Computing Facility Argonne National Laboratory