Hi, I tried to push the diff https://reviews.llvm.org/D69438 to trunk following instructions at https://llvm.org/docs/GettingStarted.html#commit-from-git Specially, I have done the following setup: $ export PATH=$PATH:$TOP_LEVEL_DIR/llvm-project/llvm/utils/git-svn/ But my `git llvm push` did not really do the push as shown below: -bash-4.4$ git llvm push `git fetch https://github.com/llvm/llvm-project.git master` printed to stderr: From https://github.com/llvm/llvm-project * branch master -> FETCH_HEAD Nothing to push -bash-4.4$ I have the commit to be pushed in my local branch as below: -bash-4.4$ git log --pretty=oneline 6fdc593fc973365dcd5cf4a582d97c0ae44900f6 (HEAD -> bug1) [BPF] fix a CO-RE issue with -mattr=+alu32 3c7c3717932aba864c23edd2e48f1b28a6d532d5 (origin/master, origin/HEAD, master) [CVP] add test for poison propagation bug (PR43802); NFC 2724d9e12960cc1d93eeabbfc9aa1bffffa041cc build: remove `LLVM_CXX_STD` extension point The `git llvm push` used to work for me. Not it stopped working. Does anybody know what have changed recently? Thanks! Yonghong
Hi Yonghong, On Fri, 25 Oct 2019 at 13:40, Y Song via llvm-dev <llvm-dev at lists.llvm.org> wrote:> The `git llvm push` used to work for me. Not it stopped working. > > Does anybody know what have changed recently?We recently switched to git and GitHub as the primary repository (yay!), so you no longer need to use "git llvm", you can push directly if you have permissions. However, since you didn't know about this it's likely you don't have permission; that was handled by adding our usernames to a magic file. So I think what you need to do now is e-mail Tom Stellard with your GitHub user details and he'll add you to the project team so you can commit. Cheers. Tim.
On Fri, Oct 25, 2019 at 2:10 PM Tim Northover <t.p.northover at gmail.com> wrote:> > Hi Yonghong, > > On Fri, 25 Oct 2019 at 13:40, Y Song via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > The `git llvm push` used to work for me. Not it stopped working. > > > > Does anybody know what have changed recently? > > We recently switched to git and GitHub as the primary repository > (yay!), so you no longer need to use "git llvm", you can push directly > if you have permissions. > > However, since you didn't know about this it's likely you don't have > permission; that was handled by adding our usernames to a magic file. > So I think what you need to do now is e-mail Tom Stellard with your > GitHub user details and he'll add you to the project team so you can > commit.Tim, Thanks for the explanation. When I hit the problem, I browsed the mailing list and found the github discussion. I just sent an email one hour back to Tom to request permission. I will wait and try again later. Yonghong> > Cheers. > > Tim.