Alina Sbirlea via llvm-dev
2019-Oct-17 18:01 UTC
[llvm-dev] Deleting BasicBlockPass/Manager
Hi, I sent out a patch (D69121 <https://reviews.llvm.org/D69121>) removing the BasicBlockPass, BasicBlockManager and all their dependencies following the patch that cleaned up the instantiations of the BasicBlockPass (rL373254 <https://reviews.llvm.org/rL373254>). The motivation was that the BasicBlockManager was generally unused, untested, was potentially broken (PR42264 <https://bugs.llvm.org/show_bug.cgi?id=42264>, PR43429 <https://bugs.llvm.org/show_bug.cgi?id=43429>, PR43336 <https://bugs.llvm.org/show_bug.cgi?id=43336>, PR42246 <https://bugs.llvm.org/show_bug.cgi?id=42246>), and any BasicBlockPass could be updated to be a FunctionPass looping over all BBs. If you have comments or concerns about this cleanup please let me know. Best, Alina -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191017/64716bb1/attachment.html>
Alina Sbirlea via llvm-dev
2019-Oct-30 21:42 UTC
[llvm-dev] Deleting BasicBlockPass/Manager
Heads up that this landed in this revision <https://github.com/llvm/llvm-project/commit/9f0ff0b2634bab6a5be8dace005c9eb24d386dd1>. Updated release notes here <https://github.com/llvm/llvm-project/commit/bbb43df0111ef29717b57bad7712d7f4c61655ac> . Best, Alina On Thu, Oct 17, 2019 at 11:01 AM Alina Sbirlea <alina.sbirlea at gmail.com> wrote:> Hi, > > I sent out a patch (D69121 <https://reviews.llvm.org/D69121>) removing > the BasicBlockPass, BasicBlockManager and all their dependencies following > the patch that cleaned up the instantiations of the BasicBlockPass ( > rL373254 <https://reviews.llvm.org/rL373254>). > > The motivation was that the BasicBlockManager was generally unused, > untested, was potentially broken (PR42264 > <https://bugs.llvm.org/show_bug.cgi?id=42264>, PR43429 > <https://bugs.llvm.org/show_bug.cgi?id=43429>, PR43336 > <https://bugs.llvm.org/show_bug.cgi?id=43336>, PR42246 > <https://bugs.llvm.org/show_bug.cgi?id=42246>), and any BasicBlockPass > could be updated to be a FunctionPass looping over all BBs. > > If you have comments or concerns about this cleanup please let me know. > > Best, > Alina >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191030/741162d7/attachment.html>