Tom Stellard via llvm-dev
2019-Oct-16 04:32 UTC
[llvm-dev] [cfe-dev] Mailing list changes this week
On 10/15/2019 09:24 PM, Mehdi AMINI wrote:> Hi Tom. > > One issue with this is that we don't have a clear "ordering" from linear revision numbers from these emails. Have we looked into continuing to generate our own emails per commits instead so that we control the format? >This actually what we are doing, we are listening for github commit events and then generating our own emails based on the data in the event. We can format the emails how ever we want, and we tried to match the current SVN format exactly. Is the some other information you would like to have in the emails to show the ordering? -Tom> Thanks, > > -- > Mehdi > > > > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote: > > Hi, > > We are going to start to switching from SVN commit emails to GitHub commit > emails this week. The only real change you should notice is that > the revision number in the subject will be replaced with a git hash and > the diff links in the email will point to GitHub. Otherwise the > content and format of the email should be the same. > > We are going to start by rolling this out for the openmp-commits list > and then once that's working begin migrating the rest of the lists. If you > notice any issues with the new emails, please file a bug and mark it > as a blocker of the github meta-bug (llvm.org/PR39393 <http://llvm.org/PR39393>). > > Thanks, > Tom > _______________________________________________ > cfe-dev mailing list > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org> > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >
Mehdi AMINI via llvm-dev
2019-Oct-16 04:44 UTC
[llvm-dev] [cfe-dev] Mailing list changes this week
On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <tstellar at redhat.com> wrote:> On 10/15/2019 09:24 PM, Mehdi AMINI wrote: > > Hi Tom. > > > > One issue with this is that we don't have a clear "ordering" from linear > revision numbers from these emails. Have we looked into continuing to > generate our own emails per commits instead so that we control the format? > > > > This actually what we are doing, we are listening for github commit events > and > then generating our own emails based on the data in the event. We can > format > the emails how ever we want, and we tried to match the current SVN format > exactly. >Ah great!> Is the some other information you would like to have in the emails to show > the > ordering? >The only thing I was looking to get was to continue to have a monotonic incrementing integer for the revision instead of the git hash alone: I don't know if `git llvm` has this feature yet but this was discussed a while ago (I don't remember if we just mentioned counting the commits in the repo from the beginning or using an invocation of `git describe` or something derived). -- Mehdi> > -Tom > > > Thanks, > > > > -- > > Mehdi > > > > > > > > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev < > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote: > > > > Hi, > > > > We are going to start to switching from SVN commit emails to GitHub > commit > > emails this week. The only real change you should notice is that > > the revision number in the subject will be replaced with a git hash > and > > the diff links in the email will point to GitHub. Otherwise the > > content and format of the email should be the same. > > > > We are going to start by rolling this out for the openmp-commits list > > and then once that's working begin migrating the rest of the lists. > If you > > notice any issues with the new emails, please file a bug and mark it > > as a blocker of the github meta-bug (llvm.org/PR39393 < > http://llvm.org/PR39393>). > > > > Thanks, > > Tom > > _______________________________________________ > > cfe-dev mailing list > > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org> > > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191015/f2fd8c00/attachment.html>
Tom Stellard via llvm-dev
2019-Oct-16 05:12 UTC
[llvm-dev] [cfe-dev] Mailing list changes this week
On 10/15/2019 09:44 PM, Mehdi AMINI wrote:> > > On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <tstellar at redhat.com <mailto:tstellar at redhat.com>> wrote: > > On 10/15/2019 09:24 PM, Mehdi AMINI wrote: > > Hi Tom. > > > > One issue with this is that we don't have a clear "ordering" from linear revision numbers from these emails. Have we looked into continuing to generate our own emails per commits instead so that we control the format? > > > > This actually what we are doing, we are listening for github commit events and > then generating our own emails based on the data in the event. We can format > the emails how ever we want, and we tried to match the current SVN format exactly. > > > Ah great! > > > Is the some other information you would like to have in the emails to show the > ordering? > > > The only thing I was looking to get was to continue to have a monotonic incrementing integer for the revision instead of the git hash alone: I don't know if `git llvm` has this feature yet but this was discussed a while ago (I don't remember if we just mentioned counting the commits in the repo from the beginning or using an invocation of `git describe` or something derived). >We talked about using `git describe` for this, but this would require that we add tags to the master branch each time the version number was bumped. We discussed this[1] last year, but deferred the decision, since we couldn't get consensus on the tag name. -Tom [1] http://lists.llvm.org/pipermail/llvm-dev/2018-December/128484.html> -- > Mehdi > > > > > -Tom > > > Thanks, > > > > -- > > Mehdi > > > > > > > > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org> <mailto:cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>>> wrote: > > > > Hi, > > > > We are going to start to switching from SVN commit emails to GitHub commit > > emails this week. The only real change you should notice is that > > the revision number in the subject will be replaced with a git hash and > > the diff links in the email will point to GitHub. Otherwise the > > content and format of the email should be the same. > > > > We are going to start by rolling this out for the openmp-commits list > > and then once that's working begin migrating the rest of the lists. If you > > notice any issues with the new emails, please file a bug and mark it > > as a blocker of the github meta-bug (llvm.org/PR39393 <http://llvm.org/PR39393> <http://llvm.org/PR39393>). > > > > Thanks, > > Tom > > _______________________________________________ > > cfe-dev mailing list > > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org> <mailto:cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> > > https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > > >