For example, the illustrate part says "ES.getMainJITDylib().setGenerator" while the full code list says "ES.getMainJITDylib().addGenerator", I guess the API is changed, the tutorial part is up to date while the full code list leaves to the old version. On Thu, Sep 19, 2019 at 10:51 AM Yafei Liu <yfliu at mobvoi.com> wrote:> Yes, the function type mismatch, just copy the "full code list" and > compile will fail. > > On Thu, Sep 19, 2019 at 3:43 AM Praveen Velliengiri < > praveenvelliengiri at gmail.com> wrote: > >> Hi Yafei, >> First 2 chapters of the tutorial is up-to-date with ORC v2 APIs. I hope >> nothing changed in docs and code. >> Did you got compilation errors? >> >> On Thu, 19 Sep 2019 at 00:47, David Blaikie via llvm-dev < >> llvm-dev at lists.llvm.org> wrote: >> >>> +Lang for JIT things >>> >>> On Tue, Sep 17, 2019 at 7:01 PM Yafei Liu via llvm-dev < >>> llvm-dev at lists.llvm.org> wrote: >>> >>>> In the Tutorial of the JIT >>>> https://llvm.org/docs/tutorial/BuildingAJIT1.html, illustrations and >>>> the full code listing are not the same, and the full code listing will not >>>> compile, this will make a lot of trouble to beginners since the JIT API is >>>> changing all the time. >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> llvm-dev at lists.llvm.org >>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org >>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>> >>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190919/d9cfd986/attachment.html>
Praveen Velliengiri via llvm-dev
2019-Sep-19 17:19 UTC
[llvm-dev] Errata: The JIT tutorial
Hi Yafei, Ahh sorry, API is changed but the docs is not updated. I will do it this weekend. Do you get any errors other than that? On Sep 19, 2019 8:26 AM, "Yafei Liu" <yfliu at mobvoi.com> wrote:> For example, the illustrate part says "ES.getMainJITDylib().setGenerator" > while the full code list says "ES.getMainJITDylib().addGenerator", I > guess the API is changed, the tutorial part is up to date while the full > code list leaves to the old version. > > On Thu, Sep 19, 2019 at 10:51 AM Yafei Liu <yfliu at mobvoi.com> wrote: > >> Yes, the function type mismatch, just copy the "full code list" and >> compile will fail. >> >> On Thu, Sep 19, 2019 at 3:43 AM Praveen Velliengiri < >> praveenvelliengiri at gmail.com> wrote: >> >>> Hi Yafei, >>> First 2 chapters of the tutorial is up-to-date with ORC v2 APIs. I hope >>> nothing changed in docs and code. >>> Did you got compilation errors? >>> >>> On Thu, 19 Sep 2019 at 00:47, David Blaikie via llvm-dev < >>> llvm-dev at lists.llvm.org> wrote: >>> >>>> +Lang for JIT things >>>> >>>> On Tue, Sep 17, 2019 at 7:01 PM Yafei Liu via llvm-dev < >>>> llvm-dev at lists.llvm.org> wrote: >>>> >>>>> In the Tutorial of the JIT https://llvm.org/docs/ >>>>> tutorial/BuildingAJIT1.html, illustrations and the full code listing >>>>> are not the same, and the full code listing will not compile, this will >>>>> make a lot of trouble to beginners since the JIT API is changing all the >>>>> time. >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> llvm-dev at lists.llvm.org >>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>>> >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> llvm-dev at lists.llvm.org >>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>> >>>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190919/23ef2300/attachment.html>
HI Praveen, no, that's the only errata I found. On Fri, Sep 20, 2019 at 1:19 AM Praveen Velliengiri < praveenvelliengiri at gmail.com> wrote:> Hi Yafei, > Ahh sorry, API is changed but the docs is not updated. I will do it this > weekend. Do you get any errors other than that? > > On Sep 19, 2019 8:26 AM, "Yafei Liu" <yfliu at mobvoi.com> wrote: > >> For example, the illustrate part says "ES.getMainJITDylib().setGenerator" >> while the full code list says "ES.getMainJITDylib().addGenerator", I >> guess the API is changed, the tutorial part is up to date while the full >> code list leaves to the old version. >> >> On Thu, Sep 19, 2019 at 10:51 AM Yafei Liu <yfliu at mobvoi.com> wrote: >> >>> Yes, the function type mismatch, just copy the "full code list" and >>> compile will fail. >>> >>> On Thu, Sep 19, 2019 at 3:43 AM Praveen Velliengiri < >>> praveenvelliengiri at gmail.com> wrote: >>> >>>> Hi Yafei, >>>> First 2 chapters of the tutorial is up-to-date with ORC v2 APIs. I hope >>>> nothing changed in docs and code. >>>> Did you got compilation errors? >>>> >>>> On Thu, 19 Sep 2019 at 00:47, David Blaikie via llvm-dev < >>>> llvm-dev at lists.llvm.org> wrote: >>>> >>>>> +Lang for JIT things >>>>> >>>>> On Tue, Sep 17, 2019 at 7:01 PM Yafei Liu via llvm-dev < >>>>> llvm-dev at lists.llvm.org> wrote: >>>>> >>>>>> In the Tutorial of the JIT >>>>>> https://llvm.org/docs/tutorial/BuildingAJIT1.html, illustrations and >>>>>> the full code listing are not the same, and the full code listing will not >>>>>> compile, this will make a lot of trouble to beginners since the JIT API is >>>>>> changing all the time. >>>>>> _______________________________________________ >>>>>> LLVM Developers mailing list >>>>>> llvm-dev at lists.llvm.org >>>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>>>> >>>>> _______________________________________________ >>>>> LLVM Developers mailing list >>>>> llvm-dev at lists.llvm.org >>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >>>>> >>>>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190920/20c72f66/attachment.html>