Zakharin, Vyacheslav P via llvm-dev
2019-Jul-17 18:42 UTC
[llvm-dev] [RFC] change .gitignore for monorepo
James, we are using an *unmodified* llvm-project (master llorg), and just add some extra projects from our internal repos to the top-level. Thanks, Slava From: James Y Knight [mailto:jyknight at google.com] Sent: Wednesday, July 17, 2019 11:19 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello, My team is using some non-llvm projects along with llvm-project monorepo. The projects are checked out to the top level of llvm-project, and ‘git status’ would complain about them unless we add them to .gitignore. We do not really want to change llorg’s .gitignore on our side, Why not? If you're using a modified llvm-project fork, what's the harm of also modifying .gitignore? so may we propose changing llorg’s .gitignore to ignore all top-level files/directories that are not explicitly listed? Something along the lines: /* !/clang !/clang-tools-extra !/compiler-rt … This will require updating .gitignore every time a new top-level entry is added into llvm-project monorepo, which should not be a big deal. Please let me know if I can proceed with a review request. I'm still against this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/3003af64/attachment.html>
Shoaib Meenai via llvm-dev
2019-Jul-17 23:21 UTC
[llvm-dev] [RFC] change .gitignore for monorepo
You can add local ignores to .git/info/exclude From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of "Zakharin, Vyacheslav P via llvm-dev" <llvm-dev at lists.llvm.org> Reply-To: "Zakharin, Vyacheslav P" <vyacheslav.p.zakharin at intel.com> Date: Wednesday, July 17, 2019 at 11:43 AM To: James Y Knight <jyknight at google.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo James, we are using an *unmodified* llvm-project (master llorg), and just add some extra projects from our internal repos to the top-level. Thanks, Slava From: James Y Knight [mailto:jyknight at google.com] Sent: Wednesday, July 17, 2019 11:19 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello, My team is using some non-llvm projects along with llvm-project monorepo. The projects are checked out to the top level of llvm-project, and ‘git status’ would complain about them unless we add them to .gitignore. We do not really want to change llorg’s .gitignore on our side, Why not? If you're using a modified llvm-project fork, what's the harm of also modifying .gitignore? so may we propose changing llorg’s .gitignore to ignore all top-level files/directories that are not explicitly listed? Something along the lines: /* !/clang !/clang-tools-extra !/compiler-rt … This will require updating .gitignore every time a new top-level entry is added into llvm-project monorepo, which should not be a big deal. Please let me know if I can proceed with a review request. I'm still against this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/d2c7e949/attachment.html>
" You can add local ignores to .git/info/exclude " Doesn't that have to be reapplied to each new clone? Making it extremely error-prone (forgetting to do the local excludes). --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Shoaib Meenai via llvm-dev Sent: Wednesday, July 17, 2019 7:22 PM To: Zakharin, Vyacheslav P; James Y Knight Cc: llvm-dev Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo You can add local ignores to .git/info/exclude From: llvm-dev <llvm-dev-bounces at lists.llvm.org> on behalf of "Zakharin, Vyacheslav P via llvm-dev" <llvm-dev at lists.llvm.org> Reply-To: "Zakharin, Vyacheslav P" <vyacheslav.p.zakharin at intel.com> Date: Wednesday, July 17, 2019 at 11:43 AM To: James Y Knight <jyknight at google.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo James, we are using an *unmodified* llvm-project (master llorg), and just add some extra projects from our internal repos to the top-level. Thanks, Slava From: James Y Knight [mailto:jyknight at google.com] Sent: Wednesday, July 17, 2019 11:19 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello, My team is using some non-llvm projects along with llvm-project monorepo. The projects are checked out to the top level of llvm-project, and ‘git status’ would complain about them unless we add them to .gitignore. We do not really want to change llorg’s .gitignore on our side, Why not? If you're using a modified llvm-project fork, what's the harm of also modifying .gitignore? so may we propose changing llorg’s .gitignore to ignore all top-level files/directories that are not explicitly listed? Something along the lines: /* !/clang !/clang-tools-extra !/compiler-rt … This will require updating .gitignore every time a new top-level entry is added into llvm-project monorepo, which should not be a big deal. Please let me know if I can proceed with a review request. I'm still against this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190718/57d18779/attachment.html>
Slava, if you have added files/directories under llvm-project/ then you no longer have an *unmodified* llvm-project. You have added something to it, and it is appropriate to modify .gitignore to allow for that. If that is the only file you have to modify, then you have the second-cheapest possible downstream situation. (The only way to make it cheaper is if all your downstream additions are siblings of llvm-project/ rather than children.) --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Zakharin, Vyacheslav P via llvm-dev Sent: Wednesday, July 17, 2019 2:43 PM To: James Y Knight Cc: llvm-dev Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo James, we are using an *unmodified* llvm-project (master llorg), and just add some extra projects from our internal repos to the top-level. Thanks, Slava From: James Y Knight [mailto:jyknight at google.com] Sent: Wednesday, July 17, 2019 11:19 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello, My team is using some non-llvm projects along with llvm-project monorepo. The projects are checked out to the top level of llvm-project, and ‘git status’ would complain about them unless we add them to .gitignore. We do not really want to change llorg’s .gitignore on our side, Why not? If you're using a modified llvm-project fork, what's the harm of also modifying .gitignore? so may we propose changing llorg’s .gitignore to ignore all top-level files/directories that are not explicitly listed? Something along the lines: /* !/clang !/clang-tools-extra !/compiler-rt … This will require updating .gitignore every time a new top-level entry is added into llvm-project monorepo, which should not be a big deal. Please let me know if I can proceed with a review request. I'm still against this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190718/734167d4/attachment.html>
Zakharin, Vyacheslav P via llvm-dev
2019-Jul-18 17:29 UTC
[llvm-dev] [RFC] change .gitignore for monorepo
Paul, Our workspace creator just checks out the other projects into the top-level structure of llvm-project, but llvm-project and the other projects are still from different repos. We could have taught the workspace creator to modify .git/info/exclude for each workspace, but as you said, it is error-prone. OK, it looks like .gitignore is not going to change, so we will have to figure out some local solution. Thanks, Slava From: paul.robinson at sony.com [mailto:paul.robinson at sony.com] Sent: Thursday, July 18, 2019 9:48 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com>; jyknight at google.com Cc: llvm-dev at lists.llvm.org Subject: RE: [llvm-dev] [RFC] change .gitignore for monorepo Slava, if you have added files/directories under llvm-project/ then you no longer have an *unmodified* llvm-project. You have added something to it, and it is appropriate to modify .gitignore to allow for that. If that is the only file you have to modify, then you have the second-cheapest possible downstream situation. (The only way to make it cheaper is if all your downstream additions are siblings of llvm-project/ rather than children.) --paulr From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Zakharin, Vyacheslav P via llvm-dev Sent: Wednesday, July 17, 2019 2:43 PM To: James Y Knight Cc: llvm-dev Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo James, we are using an *unmodified* llvm-project (master llorg), and just add some extra projects from our internal repos to the top-level. Thanks, Slava From: James Y Knight [mailto:jyknight at google.com] Sent: Wednesday, July 17, 2019 11:19 AM To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com<mailto:vyacheslav.p.zakharin at intel.com>> Cc: llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote: Hello, My team is using some non-llvm projects along with llvm-project monorepo. The projects are checked out to the top level of llvm-project, and ‘git status’ would complain about them unless we add them to .gitignore. We do not really want to change llorg’s .gitignore on our side, Why not? If you're using a modified llvm-project fork, what's the harm of also modifying .gitignore? so may we propose changing llorg’s .gitignore to ignore all top-level files/directories that are not explicitly listed? Something along the lines: /* !/clang !/clang-tools-extra !/compiler-rt … This will require updating .gitignore every time a new top-level entry is added into llvm-project monorepo, which should not be a big deal. Please let me know if I can proceed with a review request. I'm still against this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190718/2a28bccf/attachment-0001.html>