llvm dev - Jul 2019 - [RFC] change .gitignore for monorepo

Hello,

My team is using some non-llvm projects along with llvm-project monorepo.  The
projects are checked out to the top level of llvm-project, and 'git
status' would complain about them unless we add them to .gitignore.  We do
not really want to change llorg's .gitignore on our side, so may we propose
changing llorg's .gitignore to ignore all top-level files/directories that
are not explicitly listed?  Something along the lines:
/*
!/clang
!/clang-tools-extra
!/compiler-rt
...

This will require updating .gitignore every time a new top-level entry is added
into llvm-project monorepo, which should not be a big deal.  Please let me know
if I can proceed with a review request.

Thanks,
Slava

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/c345e9e3/attachment.html>

On 07/17/2019 09:45 AM, Zakharin, Vyacheslav P via llvm-dev
wrote:
> Hello,
> 
>  
> 
> My team is using some non-llvm projects along with llvm-project monorepo. 
The projects are checked out to the top level of llvm-project, and ‘git status’
would complain about them unless we add them to .gitignore.  We do not really
want to change llorg’s .gitignore on our side, so may we propose changing
llorg’s .gitignore to ignore all top-level files/directories that are not
explicitly listed?  Something along the lines:
> 
> /*
> 
> !/clang
> 
> !/clang-tools-extra
> 
> !/compiler-rt
> 
> …
> 
>  
> 
> This will require updating .gitignore every time a new top-level entry is
added into llvm-project monorepo, which should not be a big deal.  Please let me
know if I can proceed with a review request.
> 
>  
These seems like a good concept to me, but I'm not a git expert,
so I'm unsure of what potential problems (if any) this might cause.

I think this is worth submitting a review for.

-Tom
> 
> Thanks,
> 
> Slava
> 
>  
> 
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>

I proposed this before in https://reviews.llvm.org/D57400. At the time
there was some opposition to the proposal so I didn't pursue it further,
but I still think it would be very useful to do something like that so that
I don't have to continue to maintain my own exclude file.

Peter

On Wed, Jul 17, 2019 at 9:59 AM Tom Stellard via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On 07/17/2019 09:45 AM, Zakharin, Vyacheslav P via llvm-dev wrote:
> > Hello,
> >
> >
> >
> > My team is using some non-llvm projects along with llvm-project
> monorepo.  The projects are checked out to the top level of llvm-project,
> and ‘git status’ would complain about them unless we add them to
> .gitignore.  We do not really want to change llorg’s .gitignore on our
> side, so may we propose changing llorg’s .gitignore to ignore all top-level
> files/directories that are not explicitly listed?  Something along the
> lines:
> >
> > /*
> >
> > !/clang
> >
> > !/clang-tools-extra
> >
> > !/compiler-rt
> >
> > …
> >
> >
> >
> > This will require updating .gitignore every time a new top-level entry
> is added into llvm-project monorepo, which should not be a big deal.
> Please let me know if I can proceed with a review request.
> >
> >
>
> These seems like a good concept to me, but I'm not a git expert,
> so I'm unsure of what potential problems (if any) this might cause.
>
> I think this is worth submitting a review for.
>
> -Tom
>
> >
> > Thanks,
> >
> > Slava
> >
> >
> >
> >
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>

-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/058800a6/attachment.html>

I would not want to see this.  We have directories added to the top
level in our local fork of the monorepo and to have them suddenly
ignored by git would be surprising.  Yes, we could whitelist what we've
added but we would not recognize the problem until we tried to commit a
change from those directories, which happens infrequently.  I can
imagine it would take some time to realize what is going on.

                        -David

"Zakharin, Vyacheslav P via llvm-dev" <llvm-dev at
lists.llvm.org> writes:
> Hello,
>
>  
>
> My team is using some non-llvm projects along with llvm-project monorepo. 
The projects are checked out to the top level of llvm-project, and ‘git status’
would
> complain about them unless we add them to .gitignore.  We do not really
want to change llorg’s .gitignore on our side, so may we propose changing
llorg’s
> .gitignore to ignore all top-level files/directories that are not
explicitly listed?  Something along the lines:
>
> /*
>
> !/clang
>
> !/clang-tools-extra
>
> !/compiler-rt
>
> …
>
>  
>
> This will require updating .gitignore every time a new top-level entry is
added into llvm-project monorepo, which should not be a big deal.  Please let me
know if I
> can proceed with a review request.
>
>  
>
> Thanks,
>
> Slava
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

Also a -1 from me.

On 7/17/19 10:25 AM, David Greene via llvm-dev wrote:
> I would not want to see this.  We have directories added to the top
> level in our local fork of the monorepo and to have them suddenly
> ignored by git would be surprising.  Yes, we could whitelist what we've
> added but we would not recognize the problem until we tried to commit a
> change from those directories, which happens infrequently.  I can
> imagine it would take some time to realize what is going on.
>
>                          -David
>
> "Zakharin, Vyacheslav P via llvm-dev" <llvm-dev at
lists.llvm.org> writes:
>
>> Hello,
>>
>>   
>>
>> My team is using some non-llvm projects along with llvm-project
monorepo.  The projects are checked out to the top level of llvm-project, and
‘git status’ would
>> complain about them unless we add them to .gitignore.  We do not really
want to change llorg’s .gitignore on our side, so may we propose changing
llorg’s
>> .gitignore to ignore all top-level files/directories that are not
explicitly listed?  Something along the lines:
>>
>> /*
>>
>> !/clang
>>
>> !/clang-tools-extra
>>
>> !/compiler-rt
>>
>> …
>>
>>   
>>
>> This will require updating .gitignore every time a new top-level entry
is added into llvm-project monorepo, which should not be a big deal.  Please let
me know if I
>> can proceed with a review request.
>>
>>   
>>
>> Thanks,
>>
>> Slava
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hello,
>
>
>
> My team is using some non-llvm projects along with llvm-project monorepo.
> The projects are checked out to the top level of llvm-project, and ‘git
> status’ would complain about them unless we add them to .gitignore.  We do
> not really want to change llorg’s .gitignore on our side,
>
Why not? If you're using a modified llvm-project fork, what's the harm
of
also modifying .gitignore?

> so may we propose changing llorg’s .gitignore to ignore all top-level
> files/directories that are not explicitly listed?  Something along the
> lines:
>
> /*
>
> !/clang
>
> !/clang-tools-extra
>
> !/compiler-rt
>
> …
>
>
>
> This will require updating .gitignore every time a new top-level entry is
> added into llvm-project monorepo, which should not be a big deal.  Please
> let me know if I can proceed with a review request.
>
I'm still against this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/9922f667/attachment.html>

James,  we are using an *unmodified* llvm-project (master llorg), and just add
some extra projects from our internal repos to the top-level.

Thanks,
Slava

From: James Y Knight [mailto:jyknight at google.com]
Sent: Wednesday, July 17, 2019 11:19 AM
To: Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com>
Cc: llvm-dev <llvm-dev at lists.llvm.org>
Subject: Re: [llvm-dev] [RFC] change .gitignore for monorepo

On Wed, Jul 17, 2019 at 12:45 PM Zakharin, Vyacheslav P via llvm-dev
<llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>>
wrote:
Hello,

My team is using some non-llvm projects along with llvm-project monorepo.  The
projects are checked out to the top level of llvm-project, and ‘git status’
would complain about them unless we add them to .gitignore.  We do not really
want to change llorg’s .gitignore on our side,

Why not? If you're using a modified llvm-project fork, what's the harm
of also modifying .gitignore?

so may we propose changing llorg’s .gitignore to ignore all top-level
files/directories that are not explicitly listed?  Something along the lines:
/*
!/clang
!/clang-tools-extra
!/compiler-rt
…

This will require updating .gitignore every time a new top-level entry is added
into llvm-project monorepo, which should not be a big deal.  Please let me know
if I can proceed with a review request.

I'm still against this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/3003af64/attachment.html>