David Andrew Lloyd Tenty via llvm-dev
2019-Jul-09 23:10 UTC
[llvm-dev] [RFC][lit] Renaming "python-psutil" feature
<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" >Hi All,</div> <div dir="ltr" > </div> <div dir="ltr" >The current implementation of lit test timeouts needs the python psutil module to kill a process tree after a timeout. The lit feature "python-psuti" is used to indicate when it is present.</div> <div dir="ltr" > </div> <div dir="ltr" >I'm currently working on removing this dependency on the AIX platform where psutil doesn't work well (<a href="https://reviews.llvm.org/D64251" >https://reviews.llvm.org/D64251</a>).</div> <div dir="ltr" > </div> <div dir="ltr" >I'd like to propose renaming the feature to <span class="c" ><span class="bright" >"lit-max-individual-test-time", as some platforms now won't require psutil to implement this behaviour and this better reflects what is actually being required. </span></span></div> <div dir="ltr" > </div> <div dir="ltr" ><span class="c" ><span class="bright" >As far as I am aware the feature is only currently used in</span></span> lit's own test suite (though external tests could be utilizing it).</div> <div dir="ltr" > </div> <div dir="ltr" >Comments?</div> <div dir="ltr" > </div> <div dir="ltr" ><div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10.5pt" ><div dir="ltr" ><div style="font-size: 12pt; font-weight: bold; font-family: sans-serif; color: #7C7C5F;" >--</div> <div style="font-size: 12pt; font-weight: bold; font-family: sans-serif; color: #7C7C5F;" >David Tenty</div></div></div></div></div><BR>