AFAICT we traditionally only support building llvm/clang with the 2 most recent releases of Visual Studio. With the release of VS2019, what do people think of retiring VS2015 support before the next major llvm/clang release? As well as simplifying C++14 migration (admittedly only a little), this should also let us remove a number of hacks (e.g. the alignas/AlignedCharArray hack in AlignOf.h), as well as re-enabling a number of warnings in HandleLLVMOptions.cmake. I haven't noticed any build bots still referring to VS2015 (at least not by name). Simon.
+1 from me. I'd recommend waiting a week for objections before committing changes and updating the release notes. Thanks for proposing this. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190619/2bc1f065/attachment.html>
On Tue, Jun 18, 2019 at 4:11 PM Simon Pilgrim via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > AFAICT we traditionally only support building llvm/clang with the 2 most > recent releases of Visual Studio. > > With the release of VS2019, what do people think of retiring VS2015 > support before the next major llvm/clang release?+1 from me. ~Aaron> > As well as simplifying C++14 migration (admittedly only a little), this > should also let us remove a number of hacks (e.g. the > alignas/AlignedCharArray hack in AlignOf.h), as well as re-enabling a > number of warnings in HandleLLVMOptions.cmake. > > I haven't noticed any build bots still referring to VS2015 (at least not > by name). > > Simon. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
De Azevedo Piovezan, Felipe via llvm-dev
2019-Jun-19 21:05 UTC
[llvm-dev] Retiring VS2015 Support
Isn't this already covered by the compiler upgrade plan that was under discussion a while ago? The plan covers all compilers, not only VS. If I understand correctly, VS2015 is already in the "soft error" range, and it will trigger a hard CMake error next time we bump the minimum requirements. Last I heard, we were waiting for Google to finish some internal work. -----Original Message----- From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Aaron Ballman via llvm-dev Sent: Wednesday, June 19, 2019 3:38 PM To: Simon Pilgrim <llvm-dev at redking.me.uk> Cc: llvm-dev <llvm-dev at lists.llvm.org> Subject: Re: [llvm-dev] Retiring VS2015 Support On Tue, Jun 18, 2019 at 4:11 PM Simon Pilgrim via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > AFAICT we traditionally only support building llvm/clang with the 2 > most recent releases of Visual Studio. > > With the release of VS2019, what do people think of retiring VS2015 > support before the next major llvm/clang release?+1 from me. ~Aaron> > As well as simplifying C++14 migration (admittedly only a little), > this should also let us remove a number of hacks (e.g. the > alignas/AlignedCharArray hack in AlignOf.h), as well as re-enabling a > number of warnings in HandleLLVMOptions.cmake. > > I haven't noticed any build bots still referring to VS2015 (at least > not by name). > > Simon. > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev_______________________________________________ LLVM Developers mailing list llvm-dev at lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev