Shoaib Meenai via llvm-dev
2019-Jun-03 18:51 UTC
[llvm-dev] [cfe-dev] FYI: LLVM Phabricactor notifications.
IIRC Ben Hamilton was the one who set these Herald rules up. I don’t have his email, but someone who does could CC him. From: cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of cfe-dev <cfe-dev at lists.llvm.org> Reply-To: "paul.robinson at sony.com" <paul.robinson at sony.com> Date: Monday, June 3, 2019 at 11:21 AM To: "mydeveloperday at gmail.com" <mydeveloperday at gmail.com> Cc: "llvm-dev at lists.llvm.org" <llvm-dev at lists.llvm.org>, cfe-dev <cfe-dev at lists.llvm.org>, "aaron.ballman at gmail.com" <aaron.ballman at gmail.com> Subject: Re: [cfe-dev] [llvm-dev] FYI: LLVM Phabricactor notifications. The Revision won't have 'rL' in it, until after it has been committed, and the SVN revision number is assigned. That's why the particular herald rule doesn't fire until the revision is closed. There is negative value in having changes to Clang (and LLDB, and maybe others) cc'd to llvm-commits. Those projects have their own mailing lists. Spamming llvm-commits helps nobody. Maybe the problem is that Clang and LLDB commits are somehow associated with 'rL' instead of some tag of their own. I don't know anything about how that was all set up. All I know is that it's annoying and clutters up the mailing list. --paulr From: MyDeveloper Day [mailto:mydeveloperday at gmail.com] Sent: Monday, June 03, 2019 1:08 PM To: Robinson, Paul Cc: David Jones; llvm-dev; clang developer list; Aaron Ballman Subject: Re: [llvm-dev] FYI: LLVM Phabricactor notifications. Sorry maybe I didn't explain what I saw..(again sorry if this is known already and I'm stating the obvious to people who know better than me.) The Revision contains rL in the repository field, as such the herald rule will add the LLVM project.and the llvm-commit subscriber whenever the revision is updated. When the commit AutoCloses, it updates the Revision, as such if the revision still has the rL repository field then I believe the rule will fire again and add them. (post commit) This revision was automatically updated to reflect the committed changes. H270 Tag SVN LLVM revisions as LLVM<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_H270&d=DwMGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=9Uf8Mt0_7t0jF8h00RCPUYBcWFXaqLhtbAOQmmIA91Y&s=m71bOe2Vx87PcZeBSZkh-O6A-7ai42HXpnHFDm3lYeQ&e=> Conditions Passed Repository is any of rCRT, rL, rLLD, rPLO, rT Passed Revision title does not contain [private] Passed Rule passed. Action: Add projects Added Projects Added a project: LLVM<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_tag_llvm_&d=DwMGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=9Uf8Mt0_7t0jF8h00RCPUYBcWFXaqLhtbAOQmmIA91Y&s=mtsMHVtQo4rwHJ2cpHs24NqSj_WC83PaznUaoChDLHo&e=>. Action: Add subscribers Added Subscribers Added a subscriber: llvm-commits<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_p_llvm-2Dcommits_&d=DwMGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=9Uf8Mt0_7t0jF8h00RCPUYBcWFXaqLhtbAOQmmIA91Y&s=tWfhCPR2WA9Qtqa8megIhCS2C6VibY8hhO618BEdplo&e=>. Its true I'm a little surprised that the Herald rule hadn't fired earlier and added the LLVM project and llvm-commit subscriber already, unless somehow it had, but they were removed manually, but I see no trace of that in the history. Potentially you could extend the rule to say "Revision status is not any of Accepted", but I guess the whole point of that rule is to tell people watching rL that a commit for a revision marked as being part of rL has been changed Unfortunately there isn't any connection between the Revision repository and the actual repo its committed to. I do notice LLVM doesn't use the "Owners" application in Phabricator, this is an great way of ensuring code is automatically channeled to code owners/reviews for a particular area via the "Affected packages" in a hearld rule, and can be used to automate the adding of reviewers, blocking reviews, adding projects (but alas it doesn't allow the setting of the repository from what I can tell) MyDeveloperDay (Paul) On Mon, Jun 3, 2019 at 5:21 PM <paul.robinson at sony.com<mailto:paul.robinson at sony.com>> wrote: As there is no mention of the repository being change the revisions feed (https://reviews.llvm.org/D62616<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D62616&d=DwMGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=9Uf8Mt0_7t0jF8h00RCPUYBcWFXaqLhtbAOQmmIA91Y&s=4G2FTvkTW1MJZo89gdn1Qo3-JnS_rkGv5VafGjGIhDI&e=>) I suspect it was created that way, and its only as the commit fires that it gets added. (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.) Note the highlighted part of this quote from the revision-closed email: This revision was automatically updated to reflect the committed changes. Closed by commit rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The LLVM project was added at the time Phabricator saw the closing commit, not when the revision was created. If it had been added at the time the revision was created, all review emails would have gone to both lists. They did not. --paulr From: MyDeveloper Day [mailto:mydeveloperday at gmail.com<mailto:mydeveloperday at gmail.com>] Sent: Monday, June 03, 2019 11:53 AM To: Robinson, Paul Cc: dlj at google.com<mailto:dlj at google.com>; llvm-dev; clang developer list; Aaron Ballman Subject: Re: [llvm-dev] FYI: LLVM Phabricactor notifications. PaulR (sorry again if this is known knowledge)> There's no reason for Herald to be adding project LLVM/subscriber llvm-commits at the last second here.Its possible the rL (LLVM) had be added as the repository in the review on creation rather than rCFE, if thats the case then the herald rule "H270" is going to fire because it see the repository in the review, so add LLVM project and llvm-commits as a subscriber automatically. It won't care that this has gone into rCFE and not rL (I mean it does go into rL via the cfe/trunk but I'm not sure if you want to notify for that) As there is no mention of the repository being change the revisions feed (https://reviews.llvm.org/D62616<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D62616&d=DwMGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=9Uf8Mt0_7t0jF8h00RCPUYBcWFXaqLhtbAOQmmIA91Y&s=4G2FTvkTW1MJZo89gdn1Qo3-JnS_rkGv5VafGjGIhDI&e=>) I suspect it was created that way, and its only as the commit fires that it gets added. (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.) MyDeveloperDay (Paul) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190603/68b18799/attachment.html>