Hi all, I'm new to llvm development and I have basic (beginner level) questions regarding the workflow of the llvm project. I want to clarify that the following steps is the workflow of the llvm project to prepare and submit a patch. 1. Clone the git repo (master) and create a branch named "test branch". 2. Make changes to the "test branch" and git fetch all the changes from remote origin to local master. 3. Rebase the "test branch" onto the local master. 4. Merge the test branch to master then start building and testing the master branch. 5. If nothing breaks, then I can create a diff file by git show HEAD -U999999 > mypatch.patch from the "master" 6. Upload the patch in the differential and submit for review. Am I missing something? If so, please let me know, it will very helpful for me to start :) If you have any suggestions I would happy to hear from you. LLVM is a fast moving, how often I need to fetch, rebase and build. In my machine building takes about 40 minutes is there any efficient way around this? Thank you. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190510/16e86740/attachment.html>
On Thu, May 9, 2019 at 12:54 PM Praveen Velliengiri via llvm-dev <llvm-dev at lists.llvm.org> wrote:> > Hi all, > I'm new to llvm development and I have basic (beginner level) questions regarding the workflow of the llvm project. I want to clarify that the following steps is the workflow of the llvm project to prepare and submit a patch. > > Clone the git repo (master) and create a branch named "test branch". > Make changes to the "test branch" and git fetch all the changes from remote origin to local master. > Rebase the "test branch" onto the local master. > Merge the test branch to master then start building and testing the master branch. > If nothing breaks, then I can create a diff file by git show HEAD -U999999 > mypatch.patch from the "master" > Upload the patch in the differential and submit for review. >This looks ok to me. There's also the directions at: https://llvm.org/docs/Contributing.html> Am I missing something? If so, please let me know, it will very helpful for me to start :) If you have any suggestions I would happy to hear from you. > LLVM is a fast moving, how often I need to fetch, rebase and build. In my machine building takes about 40 minutes is there any efficient way around this? >"Recently" is probably just fine, and yeah. LLVM takes a bit to build. Depending on platform there are probably some ways to speed it up slightly. -eric
Thank you, I will try these out :) On Fri, 10 May 2019 at 02:22, Eric Christopher <echristo at gmail.com> wrote:> On Thu, May 9, 2019 at 12:54 PM Praveen Velliengiri via llvm-dev > <llvm-dev at lists.llvm.org> wrote: > > > > Hi all, > > I'm new to llvm development and I have basic (beginner level) questions > regarding the workflow of the llvm project. I want to clarify that the > following steps is the workflow of the llvm project to prepare and submit a > patch. > > > > Clone the git repo (master) and create a branch named "test branch". > > Make changes to the "test branch" and git fetch all the changes from > remote origin to local master. > > Rebase the "test branch" onto the local master. > > Merge the test branch to master then start building and testing the > master branch. > > If nothing breaks, then I can create a diff file by git show HEAD > -U999999 > mypatch.patch from the "master" > > Upload the patch in the differential and submit for review. > > > > This looks ok to me. There's also the directions at: > https://llvm.org/docs/Contributing.html > > > Am I missing something? If so, please let me know, it will very helpful > for me to start :) If you have any suggestions I would happy to hear from > you. > > LLVM is a fast moving, how often I need to fetch, rebase and build. In > my machine building takes about 40 minutes is there any efficient way > around this? > > > > "Recently" is probably just fine, and yeah. LLVM takes a bit to build. > Depending on platform there are probably some ways to speed it up > slightly. > > -eric >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190510/857e2dcb/attachment.html>