Chandler Carruth via llvm-dev
2019-Jan-18 03:24 UTC
[llvm-dev] [cfe-dev] Shortest RFC ever: I propose we rename files using `.TXT` extension to use `.txt`
I mean, I can try to get these to not be "renames" in svn... but surely modern windows SVN clients handle this correctly? (and git clienst?) On Thu, Jan 17, 2019 at 7:12 PM Michael Kruse <cfe-dev at meinersbur.de> wrote:> The problem here might be git trying to rename 'file.TXT' to > 'file.txt', which results in an error on Windows since it sees both as > the same name. > > > https://stackoverflow.com/questions/10523849/changing-capitalization-of-filenames-in-git > > https://stackoverflow.com/questions/8604535/git-rebase-issue-with-files-of-same-name-but-different-case > > https://stackoverflow.com/questions/6899582/i-change-the-capitalization-of-a-directory-and-git-doesnt-seem-to-pick-up-on-it > > Some problems on Windows/MacOS systems are possible. > > Michael > > Am Do., 17. Jan. 2019 um 20:53 Uhr schrieb Chandler Carruth via > cfe-dev <cfe-dev at lists.llvm.org>: > > > > On Thu, Jan 17, 2019 at 6:51 PM Hubert Tong < > hubert.reinterpretcast at gmail.com> wrote: > >> > >> I'm wondering if this would wreak havoc upon semi-case-sensitive > systems like Windows. I'd like to hear from people who use Git and SVN on > Windows. > > > > > > FWIW, I will of course not do this in any case where there might be a > collision due to such file systems. I don't think there are any such cases > however. > > > >> > >> > >> -- HT > >> > >> On Thu, Jan 17, 2019 at 9:43 PM Chandler Carruth via cfe-dev < > cfe-dev at lists.llvm.org> wrote: > >>> > >>> Why? Because we have a mixture scattered about the codebase, but only > a very few with `.TXT`. I like consistency. It makes my obsessive > tendancies happy. > >>> > >>> Is this important? Nope. > >>> > >>> Why am I asking first? Because its possible someone, somewhere will be > disrupted by this so I figured I'd ask first. > >>> > >>> -Chandler > >>> _______________________________________________ > >>> cfe-dev mailing list > >>> cfe-dev at lists.llvm.org > >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > > > > _______________________________________________ > > cfe-dev mailing list > > cfe-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/1ec84d3a/attachment.html>
Zachary Turner via llvm-dev
2019-Jan-18 03:27 UTC
[llvm-dev] [cfe-dev] Shortest RFC ever: I propose we rename files using `.TXT` extension to use `.txt`
Yea, I honestly don't think this will be a problem. I'm happy to help you test this in the office one day, you can just check in a test file, i'll sync, then rename with different case and check it in again, and I'll sync. But I'm with you. I'd be very surprised if this is a problem on modern clients. On Thu, Jan 17, 2019 at 7:24 PM Chandler Carruth via llvm-dev < llvm-dev at lists.llvm.org> wrote:> I mean, I can try to get these to not be "renames" in svn... but surely > modern windows SVN clients handle this correctly? (and git clienst?) > > On Thu, Jan 17, 2019 at 7:12 PM Michael Kruse <cfe-dev at meinersbur.de> > wrote: > >> The problem here might be git trying to rename 'file.TXT' to >> 'file.txt', which results in an error on Windows since it sees both as >> the same name. >> >> >> https://stackoverflow.com/questions/10523849/changing-capitalization-of-filenames-in-git >> >> https://stackoverflow.com/questions/8604535/git-rebase-issue-with-files-of-same-name-but-different-case >> >> https://stackoverflow.com/questions/6899582/i-change-the-capitalization-of-a-directory-and-git-doesnt-seem-to-pick-up-on-it >> >> Some problems on Windows/MacOS systems are possible. >> >> Michael >> >> Am Do., 17. Jan. 2019 um 20:53 Uhr schrieb Chandler Carruth via >> cfe-dev <cfe-dev at lists.llvm.org>: >> > >> > On Thu, Jan 17, 2019 at 6:51 PM Hubert Tong < >> hubert.reinterpretcast at gmail.com> wrote: >> >> >> >> I'm wondering if this would wreak havoc upon semi-case-sensitive >> systems like Windows. I'd like to hear from people who use Git and SVN on >> Windows. >> > >> > >> > FWIW, I will of course not do this in any case where there might be a >> collision due to such file systems. I don't think there are any such cases >> however. >> > >> >> >> >> >> >> -- HT >> >> >> >> On Thu, Jan 17, 2019 at 9:43 PM Chandler Carruth via cfe-dev < >> cfe-dev at lists.llvm.org> wrote: >> >>> >> >>> Why? Because we have a mixture scattered about the codebase, but only >> a very few with `.TXT`. I like consistency. It makes my obsessive >> tendancies happy. >> >>> >> >>> Is this important? Nope. >> >>> >> >>> Why am I asking first? Because its possible someone, somewhere will >> be disrupted by this so I figured I'd ask first. >> >>> >> >>> -Chandler >> >>> _______________________________________________ >> >>> cfe-dev mailing list >> >>> cfe-dev at lists.llvm.org >> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >> > >> > _______________________________________________ >> > cfe-dev mailing list >> > cfe-dev at lists.llvm.org >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >> > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/79c002a7/attachment.html>
Chandler Carruth via llvm-dev
2019-Jan-18 03:28 UTC
[llvm-dev] [cfe-dev] Shortest RFC ever: I propose we rename files using `.TXT` extension to use `.txt`
Cool, before doing anything, I'll work w/ Zach to confirm. (Thanks Zach!) Any other concerns? On Thu, Jan 17, 2019 at 7:27 PM Zachary Turner <zturner at google.com> wrote:> Yea, I honestly don't think this will be a problem. I'm happy to help you > test this in the office one day, you can just check in a test file, i'll > sync, then rename with different case and check it in again, and I'll > sync. But I'm with you. I'd be very surprised if this is a problem on > modern clients. > > On Thu, Jan 17, 2019 at 7:24 PM Chandler Carruth via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > >> I mean, I can try to get these to not be "renames" in svn... but surely >> modern windows SVN clients handle this correctly? (and git clienst?) >> >> On Thu, Jan 17, 2019 at 7:12 PM Michael Kruse <cfe-dev at meinersbur.de> >> wrote: >> >>> The problem here might be git trying to rename 'file.TXT' to >>> 'file.txt', which results in an error on Windows since it sees both as >>> the same name. >>> >>> >>> https://stackoverflow.com/questions/10523849/changing-capitalization-of-filenames-in-git >>> >>> https://stackoverflow.com/questions/8604535/git-rebase-issue-with-files-of-same-name-but-different-case >>> >>> https://stackoverflow.com/questions/6899582/i-change-the-capitalization-of-a-directory-and-git-doesnt-seem-to-pick-up-on-it >>> >>> Some problems on Windows/MacOS systems are possible. >>> >>> Michael >>> >>> Am Do., 17. Jan. 2019 um 20:53 Uhr schrieb Chandler Carruth via >>> cfe-dev <cfe-dev at lists.llvm.org>: >>> > >>> > On Thu, Jan 17, 2019 at 6:51 PM Hubert Tong < >>> hubert.reinterpretcast at gmail.com> wrote: >>> >> >>> >> I'm wondering if this would wreak havoc upon semi-case-sensitive >>> systems like Windows. I'd like to hear from people who use Git and SVN on >>> Windows. >>> > >>> > >>> > FWIW, I will of course not do this in any case where there might be a >>> collision due to such file systems. I don't think there are any such cases >>> however. >>> > >>> >> >>> >> >>> >> -- HT >>> >> >>> >> On Thu, Jan 17, 2019 at 9:43 PM Chandler Carruth via cfe-dev < >>> cfe-dev at lists.llvm.org> wrote: >>> >>> >>> >>> Why? Because we have a mixture scattered about the codebase, but >>> only a very few with `.TXT`. I like consistency. It makes my obsessive >>> tendancies happy. >>> >>> >>> >>> Is this important? Nope. >>> >>> >>> >>> Why am I asking first? Because its possible someone, somewhere will >>> be disrupted by this so I figured I'd ask first. >>> >>> >>> >>> -Chandler >>> >>> _______________________________________________ >>> >>> cfe-dev mailing list >>> >>> cfe-dev at lists.llvm.org >>> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >>> > >>> > _______________________________________________ >>> > cfe-dev mailing list >>> > cfe-dev at lists.llvm.org >>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >>> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190117/eb170c50/attachment.html>
via llvm-dev
2019-Jan-18 16:58 UTC
[llvm-dev] [cfe-dev] Shortest RFC ever: I propose we rename files using `.TXT` extension to use `.txt`
> -----Original Message----- > From: cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] On Behalf Of Jacob > Carlborg via cfe-dev > Sent: Friday, January 18, 2019 5:40 AM > To: cfe-dev at lists.llvm.org > Cc: llvm-dev at lists.llvm.org > Subject: Re: [cfe-dev] [llvm-dev] Shortest RFC ever: I propose we rename > files using `.TXT` extension to use `.txt` > > On 2019-01-18 04:27, Zachary Turner via cfe-dev wrote: > > Yea, I honestly don't think this will be a problem. I'm happy to help > > you test this in the office one day, you can just check in a test file, > > i'll sync, then rename with different case and check it in again, and > > I'll sync. But I'm with you. I'd be very surprised if this is a > > problem on modern clients. > > On macOS (which uses a case-insensitive) filesystem "git mv" works as > expected. But if you use the regular "mv" command "git status" will not > see the file as being renamed.FTR, on Windows I have accidentally done things like git add lib/debuginfo/foobar which works totally fine, until you try to checkout on Linux, where you will discover you have both a lib/DebugInfo and a lib/debuginfo directory sitting side-by-side, and your build dies mysteriously. I would *never* be sanguine about multi-platform tools like git or svn behaving "the way you expect" when it comes to filespec case. --paulr> > -- > /Jacob Carlborg > > _______________________________________________ > cfe-dev mailing list > cfe-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Nico Weber via llvm-dev
2019-Jan-18 19:43 UTC
[llvm-dev] [cfe-dev] Shortest RFC ever: I propose we rename files using `.TXT` extension to use `.txt`
I did a case-only rename in https://reviews.llvm.org/rL272701 . There were similar concerns, but it worked out fine. I had tested that it works on Windows before doing it. I did that through svn. So I too think this shouldn't be an issue. On Fri, Jan 18, 2019 at 11:59 AM via cfe-dev <cfe-dev at lists.llvm.org> wrote:> > > > -----Original Message----- > > From: cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] On Behalf Of Jacob > > Carlborg via cfe-dev > > Sent: Friday, January 18, 2019 5:40 AM > > To: cfe-dev at lists.llvm.org > > Cc: llvm-dev at lists.llvm.org > > Subject: Re: [cfe-dev] [llvm-dev] Shortest RFC ever: I propose we rename > > files using `.TXT` extension to use `.txt` > > > > On 2019-01-18 04:27, Zachary Turner via cfe-dev wrote: > > > Yea, I honestly don't think this will be a problem. I'm happy to help > > > you test this in the office one day, you can just check in a test file, > > > i'll sync, then rename with different case and check it in again, and > > > I'll sync. But I'm with you. I'd be very surprised if this is a > > > problem on modern clients. > > > > On macOS (which uses a case-insensitive) filesystem "git mv" works as > > expected. But if you use the regular "mv" command "git status" will not > > see the file as being renamed. > > FTR, on Windows I have accidentally done things like > > git add lib/debuginfo/foobar > > which works totally fine, until you try to checkout on Linux, where > you will discover you have both a lib/DebugInfo and a lib/debuginfo > directory sitting side-by-side, and your build dies mysteriously. > > I would *never* be sanguine about multi-platform tools like git or svn > behaving "the way you expect" when it comes to filespec case. > --paulr > > > > > -- > > /Jacob Carlborg > > > > _______________________________________________ > > cfe-dev mailing list > > cfe-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev > _______________________________________________ > cfe-dev mailing list > cfe-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190118/dcae3d49/attachment.html>