Chandler Carruth via llvm-dev <llvm-dev at lists.llvm.org> writes:> What you're seeing is just the fact that lit is waiting on > subprocesses (select is waiting on the pipes i suspect).Right. Some digging revealed that it is waiting on getline_nohang.cc.tmp, a tsan test. I see that this test has been disabled for NetBSD, due to it sometimes failing. I'm seeing the same on Linux. How can we stabilize the sanitizer tests so that check-all can work reliably? If some sanitizer tests are so flaky, I should think they should be marked UNSUPPORTED. Who has the authority to make those determinations? -David
> On Jan 3, 2019, at 1:21 PM, David Greene via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > Chandler Carruth via llvm-dev <llvm-dev at lists.llvm.org> writes: > >> What you're seeing is just the fact that lit is waiting on >> subprocesses (select is waiting on the pipes i suspect). > > Right. Some digging revealed that it is waiting on > getline_nohang.cc.tmp, a tsan test. > > I see that this test has been disabled for NetBSD, due to it sometimes > failing. I'm seeing the same on Linux. > > How can we stabilize the sanitizer tests so that check-all can work > reliably? If some sanitizer tests are so flaky, I should think they > should be marked UNSUPPORTED. Who has the authority to make those > determinations?Dmitry Vyukov does. CC'ing him. Kuba> > -David > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
On Thu, Jan 3, 2019 at 11:54 PM Kuba Mracek <mracek at apple.com> wrote:> > > > > On Jan 3, 2019, at 1:21 PM, David Greene via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > > > Chandler Carruth via llvm-dev <llvm-dev at lists.llvm.org> writes: > > > >> What you're seeing is just the fact that lit is waiting on > >> subprocesses (select is waiting on the pipes i suspect). > > > > Right. Some digging revealed that it is waiting on > > getline_nohang.cc.tmp, a tsan test. > > > > I see that this test has been disabled for NetBSD, due to it sometimes > > failing. I'm seeing the same on Linux. > > > > How can we stabilize the sanitizer tests so that check-all can work > > reliably? If some sanitizer tests are so flaky, I should think they > > should be marked UNSUPPORTED. Who has the authority to make those > > determinations? > > Dmitry Vyukov does. CC'ing him.Are there any special repro instructions? I am running all tsan tests periodically on linux and none of them flakes.