llvm dev - Dec 2018 - kaleidoscope ch4 jit example regression?

https://llvm.org/docs/tutorial/LangImpl04.html has an example where
the function `foo` gets redefined, and the JIT returns evaluation of
the latest definition.  I thought my code was wrong, but it seems that
the binary produced by `ninja Kaleidoscope-Ch4` has the same bug.

Granted, my LLVM checkout is from Nov 3 2018 (r346062).  Is this a known issue?
~Nick Desaulniers

+Lang who does JIT things

Yeah, I can confirm my local build (using LLVM source from today) of
Chapter 4 behaves as you describe, and not as the documentation shows.
Looks like somethnig needs updating (either source or the documentation).

On Sun, Dec 30, 2018 at 3:28 PM Nick Desaulniers via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> https://llvm.org/docs/tutorial/LangImpl04.html has an example where
> the function `foo` gets redefined, and the JIT returns evaluation of
> the latest definition.  I thought my code was wrong, but it seems that
> the binary produced by `ninja Kaleidoscope-Ch4` has the same bug.
>
> Granted, my LLVM checkout is from Nov 3 2018 (r346062).  Is this a known
> issue?
> ~Nick Desaulniers
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190120/08acd95d/attachment.html>

Hi Nick,

I was not aware of it, but it makes sense given the recent switch to ORC2, which
has different symbol resolution rules.

I am out on vacation this week, but will take a look when I get back and see if
I can restore the old behavior.

Cheers,
Lang.

Sent from my iPhone
> On Jan 20, 2019, at 2:14 PM, David Blaikie <dblaikie at gmail.com>
wrote:
> 
> +Lang who does JIT things
> 
> Yeah, I can confirm my local build (using LLVM source from today) of
Chapter 4 behaves as you describe, and not as the documentation shows. Looks
like somethnig needs updating (either source or the documentation).
> 
>> On Sun, Dec 30, 2018 at 3:28 PM Nick Desaulniers via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>> https://llvm.org/docs/tutorial/LangImpl04.html has an example where
>> the function `foo` gets redefined, and the JIT returns evaluation of
>> the latest definition.  I thought my code was wrong, but it seems that
>> the binary produced by `ninja Kaleidoscope-Ch4` has the same bug.
>> 
>> Granted, my LLVM checkout is from Nov 3 2018 (r346062).  Is this a
known issue?
>> ~Nick Desaulniers
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20190121/6de0156d/attachment.html>