llvm dev - Nov 2018 - GlobalVariable::eraseFromParent

I am confused by GlobalVariable::eraseFromParent's declaration:

  /// This method unlinks 'this' from the containing module and deletes
it.
  void eraseFromParent();

In Globals.cpp the unlinking is done and SymbolTableListTraits cleans up
the symbol table but I don't see anything that actually deletes the
object.  Is the comment misleading or am I missing something?

                           -David

Deletion is taken care of by ilist_alloc_traits<T>::deleteNode.

On Tue, Nov 27, 2018 at 7:45 AM David Greene via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> I am confused by GlobalVariable::eraseFromParent's declaration:
>
>   /// This method unlinks 'this' from the containing module and
deletes it.
>   void eraseFromParent();
>
> In Globals.cpp the unlinking is done and SymbolTableListTraits cleans up
> the symbol table but I don't see anything that actually deletes the
> object.  Is the comment misleading or am I missing something?
>
>                            -David
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20181127/ae512fc7/attachment.html>

Thanks.  I realized I was looking at ilist instead of iplist.  :-/

                          -David

Reid Kleckner <rnk at google.com> writes:
> Deletion is taken care of by ilist_alloc_traits<T>::deleteNode.
>
> On Tue, Nov 27, 2018 at 7:45 AM David Greene via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>
>     I am confused by GlobalVariable::eraseFromParent's declaration:
>     
>     /// This method unlinks 'this' from the containing module and
>     deletes it.
>     void eraseFromParent();
>     
>     In Globals.cpp the unlinking is done and SymbolTableListTraits
>     cleans up
>     the symbol table but I don't see anything that actually deletes
>     the
>     object. Is the comment misleading or am I missing something?
>     
>     -David
>     _______________________________________________
>     LLVM Developers mailing list
>     llvm-dev at lists.llvm.org
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev