On 02/10/18 22:58, Friedman, Eli via llvm-dev wrote:> On 10/2/2018 2:27 PM, via llvm-dev wrote: >> At CPPcon last week, I saw a talk by Bob Steagall called >> "Fast Conversion From UTF-8 with C++, DFAs, and SSE Intrinsics." >> Part of this talk included data from a half-dozen or so conversion >> libraries... one of which was labeled "LLVM". >> >> The LLVM converters were invariably the slowest. > > UTF conversion is not on any hot paths, as far as I know, so nobody has > spent any time optimizing it. If you're interested in the history of > the LLVM code, see https://reviews.llvm.org/rC68208 ; it's mostly > untouched since then, except for a few bugfixes.Given https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100 https://bugs.llvm.org/show_bug.cgi?id=32962 I think moving away from it should be encouraged, assuming use of that file can be removed. Thanks, Stephen.
On Wed, Oct 03, 2018 at 09:14:30AM +0100, Stephen Kelly via llvm-dev wrote:> On 02/10/18 22:58, Friedman, Eli via llvm-dev wrote: > > On 10/2/2018 2:27 PM, via llvm-dev wrote: > > > At CPPcon last week, I saw a talk by Bob Steagall called > > > "Fast Conversion From UTF-8 with C++, DFAs, and SSE Intrinsics." > > > Part of this talk included data from a half-dozen or so conversion > > > libraries... one of which was labeled "LLVM". > > > > > > The LLVM converters were invariably the slowest. > > > > UTF conversion is not on any hot paths, as far as I know, so nobody has > > spent any time optimizing it. If you're interested in the history of > > the LLVM code, see https://reviews.llvm.org/rC68208 ; it's mostly > > untouched since then, except for a few bugfixes. > > Given > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100 > > https://bugs.llvm.org/show_bug.cgi?id=32962 > > I think moving away from it should be encouraged, assuming use of that file > can be removed.That bug is clearly bogus. Whether the copyright indication is correct is a separate question, but the claim of the PR is just wrong. Joerg
Probably best to leave the license lawyering to lawyers & not public mailing lists. On Wed, Oct 3, 2018 at 3:55 AM Joerg Sonnenberger via llvm-dev < llvm-dev at lists.llvm.org> wrote:> On Wed, Oct 03, 2018 at 09:14:30AM +0100, Stephen Kelly via llvm-dev wrote: > > On 02/10/18 22:58, Friedman, Eli via llvm-dev wrote: > > > On 10/2/2018 2:27 PM, via llvm-dev wrote: > > > > At CPPcon last week, I saw a talk by Bob Steagall called > > > > "Fast Conversion From UTF-8 with C++, DFAs, and SSE Intrinsics." > > > > Part of this talk included data from a half-dozen or so conversion > > > > libraries... one of which was labeled "LLVM". > > > > > > > > The LLVM converters were invariably the slowest. > > > > > > UTF conversion is not on any hot paths, as far as I know, so nobody has > > > spent any time optimizing it. If you're interested in the history of > > > the LLVM code, see https://reviews.llvm.org/rC68208 ; it's mostly > > > untouched since then, except for a few bugfixes. > > > > Given > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823100 > > > > https://bugs.llvm.org/show_bug.cgi?id=32962 > > > > I think moving away from it should be encouraged, assuming use of that > file > > can be removed. > > That bug is clearly bogus. Whether the copyright indication is correct > is a separate question, but the claim of the PR is just wrong. > > Joerg > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20181003/39505ad2/attachment.html>