llvm dev - Feb 2018 - Collecting address ranges in DWARFUnit::collectAddressRanges.

I expect r324738 will break on windows,

as I mentioned I had to change


CHECK: ./test.cpp:2:51

to

CHECK: {\\|/}}test.cpp:2:51

?

Best regards,
George | Developer | Access Softek, Inc
________________________________
От: David Blaikie <dblaikie at gmail.com>
Отправлено: 9 февраля 2018 г. 18:35
Кому: George Rimar
Копия: Robinson, Paul; llvm-dev at lists.llvm.org; Rafael Avila de Espindola
Тема: Re: [llvm-dev] Collecting address ranges in
DWARFUnit::collectAddressRanges.

Nah, doesn't look like it. Removed it (& the place I copied it from) in:
r324738

Thanks!

On Fri, Feb 9, 2018 at 7:28 AM George Rimar <grimar at
accesssoftek.com<mailto:grimar at accesssoftek.com>> wrote:
>Totally fair call, sorry it took me a while to come back around to this -
added in r324702
Thanks ! Have a question: does it need "requres shell" ?
I tried without and it worked for me under windows (had to change check to
CHECK: .{{\\|/}}test.cpp:2:51 though).
And I see nothing special probably that might require shell I think. We use
cd/rm/cp in LLD testcases
without requiring shell.
(also noticed other tests do that, so it seems consistent, though did not look
deeply)

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180209/69dae95f/attachment.html>

Ah, sorry, thanks - removed the "./" prefix entirely. Hope that works
- if
you happen to test it & find it doesn't, please let me know :)

On Fri, Feb 9, 2018 at 7:38 AM George Rimar <grimar at accesssoftek.com>
wrote:
> I expect r324738 will break on windows,
>
> as I mentioned I had to change
>
>
> CHECK: ./test.cpp:2:51
>
> to
>
> CHECK: {\\|/}}test.cpp:2:51
>
> ​
> Best regards,
> George | Developer | Access Softek, Inc
> ------------------------------
> *От:* David Blaikie <dblaikie at gmail.com>
> *Отправлено:* 9 февраля 2018 г. 18:35
> *Кому:* George Rimar
> *Копия:* Robinson, Paul; llvm-dev at lists.llvm.org; Rafael Avila de
> Espindola
> *Тема:* Re: [llvm-dev] Collecting address ranges in
> DWARFUnit::collectAddressRanges.
>
> Nah, doesn't look like it. Removed it (& the place I copied it
from) in:
> r324738
>
> Thanks!
>
> On Fri, Feb 9, 2018 at 7:28 AM George Rimar <grimar at
accesssoftek.com>
> wrote:
>
>> >Totally fair call, sorry it took me a while to come back around to
this
>> - added in r324702
>>
>> Thanks ! Have a question: does it need "requres shell" ?
>> I tried without and it worked for me under windows (had to change check
>> to CHECK: .{{\\|/}}test.cpp:2:51 though).
>> And I see nothing special probably that might require shell I think. We
>> use cd/rm/cp in LLD testcases
>> without requiring shell.
>> (also noticed other tests do that, so it seems consistent, though did
not
>> look deeply)
>>
>> George.
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180209/9a9626a5/attachment.html>

>Ah, sorry, thanks - removed the "./" prefix entirely. Hope that
works - if you happen to test it & find it doesn't, please let me know
:)
Thanks ! Both tests pass fine for me now.
(I was unsure if "./" is a part of testcase that is useful or not to
remove it) :)
?
George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180209/c5e0130e/attachment.html>