Mehdi Amini via llvm-dev
2016-Dec-09 00:13 UTC
[llvm-dev] Issues with DummyCGSCCPass used for IPRA
Hi, There are two relevant hooks for you immutable pass: 1) releaseMemory() 2) doFinalization() Are you looking at the first one? I think you should act on the second instead and it should solve your issue. — Mehdi> On Dec 8, 2016, at 10:58 AM, Maxime Chevalier-Boisvert via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > We have our own subtarget, with its own pipeline and set of passes. > > The problem I’m facing, as explained, is that adding the DummyCGSCCPass to our pipeline causes an early pass to be finalized when it shouldn’t be. The information then becomes unavailable when needed, in the machine code generation part of our pipeline. > > It’s unclear to us why this is happening. I was hoping someone familiar with the pass manager may have advice, or that someone may have run into a similar problem before. > > - Maxime > >> On Dec 7, 2016, at 9:46 PM, vivek pandya via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> >> >> Hello, >> >> I'm trying to enable interprocedural register allocation (IPRA). >> Hi Maxime, >> >> I don't understand here why you need to enable IPRA as that is already scheduled based on option -mllvm -enable-ipra. So I think easy way to make IPRA execute every time is to set default value of EnableIPRA option to true. >> you can find this option defined in lib/CodeGen/TargetMachine.cpp and you may also need to change its initialization to true in TargetOptions constructor in include/llvm/Target/TargetOptions.h >> >> - Vivek >> In order to do this, I’ve added the DummyCGSCCPass to our pipeline, as is done in TargetPassConfig::addISelPrepare. My understanding is that this pass wraps the following passes into an SCC pass manager, so that they are run in bottom-up order, which is necessary to enable register allocation info from callees to be available at call sites. >> >> The problem I’m running into is that we have an ImmutablePass which is run early in our pipeline (and needed in later machine code generation stages), and for some reason, this pass gets finalized and re-run multiple times, destroying the information we need in the process. I’m really not sure what is happening. The pass is clearly marked as required by later passes, but somehow it is found to be “dead”, finalized, and then re-run. To make matters more confusing, we have another ImmutablePass which is run early and used late, but this one doesn’t get finalized. My coworkers and I are really not sure what the difference might be. >> >> Could someone more familiar with IPRA or the PassManager provide some hints as to what might be happening? >> >> Regards, >> >> - Maxime >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161208/193cedbc/attachment.html>
Maxime Chevalier-Boisvert via llvm-dev
2016-Dec-09 01:09 UTC
[llvm-dev] Issues with DummyCGSCCPass used for IPRA
You’re saying that we shouldn’t release resources until doFinalization? That doesn’t seem like it solves the fundamental issue. The pass in question has its results cleared and recomputed multiple times. We don’t really understand why our pass is marked as dead when it’s needed later in the pipeline. - Maxime> On Dec 8, 2016, at 4:13 PM, Mehdi Amini <mehdi.amini at apple.com> wrote: > > Hi, > > There are two relevant hooks for you immutable pass: > > 1) releaseMemory() > 2) doFinalization() > > Are you looking at the first one? I think you should act on the second instead and it should solve your issue. > > — > Mehdi > > >> On Dec 8, 2016, at 10:58 AM, Maxime Chevalier-Boisvert via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >> >> We have our own subtarget, with its own pipeline and set of passes. >> >> The problem I’m facing, as explained, is that adding the DummyCGSCCPass to our pipeline causes an early pass to be finalized when it shouldn’t be. The information then becomes unavailable when needed, in the machine code generation part of our pipeline. >> >> It’s unclear to us why this is happening. I was hoping someone familiar with the pass manager may have advice, or that someone may have run into a similar problem before. >> >> - Maxime >> >>> On Dec 7, 2016, at 9:46 PM, vivek pandya via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >>> >>> >>> >>> Hello, >>> >>> I'm trying to enable interprocedural register allocation (IPRA). >>> Hi Maxime, >>> >>> I don't understand here why you need to enable IPRA as that is already scheduled based on option -mllvm -enable-ipra. So I think easy way to make IPRA execute every time is to set default value of EnableIPRA option to true. >>> you can find this option defined in lib/CodeGen/TargetMachine.cpp and you may also need to change its initialization to true in TargetOptions constructor in include/llvm/Target/TargetOptions.h >>> >>> - Vivek >>> In order to do this, I’ve added the DummyCGSCCPass to our pipeline, as is done in TargetPassConfig::addISelPrepare. My understanding is that this pass wraps the following passes into an SCC pass manager, so that they are run in bottom-up order, which is necessary to enable register allocation info from callees to be available at call sites. >>> >>> The problem I’m running into is that we have an ImmutablePass which is run early in our pipeline (and needed in later machine code generation stages), and for some reason, this pass gets finalized and re-run multiple times, destroying the information we need in the process. I’m really not sure what is happening. The pass is clearly marked as required by later passes, but somehow it is found to be “dead”, finalized, and then re-run. To make matters more confusing, we have another ImmutablePass which is run early and used late, but this one doesn’t get finalized. My coworkers and I are really not sure what the difference might be. >>> >>> Could someone more familiar with IPRA or the PassManager provide some hints as to what might be happening? >>> >>> Regards, >>> >>> - Maxime >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161208/5cad5ab1/attachment.html>
Mehdi Amini via llvm-dev
2016-Dec-09 01:32 UTC
[llvm-dev] Issues with DummyCGSCCPass used for IPRA
> On Dec 8, 2016, at 5:09 PM, Maxime Chevalier-Boisvert <maximecb at apple.com> wrote: > > You’re saying that we shouldn’t release resources until doFinalization?Yes: this seems to be the semantic of your pass, you *need* to keep the results alive for the duration of the pipeline on the module you are processing for it to be correct. The doInitialization() and doFinalization() methods are the boundaries that indicates when the pass manager starts a module and end a module.> That doesn’t seem like it solves the fundamental issue. The pass in question has its results cleared and recomputed multiple times. We don’t really understand why our pass is marked as dead when it’s needed later in the pipeline.The fact that it is needed later is not enough, to avoid getting a call to “releaseMemory()” it also has to be marked as preserved by every single pass in the pipeline. Basically your ImmutableAnalysis is a kind of “manually managed” analysis with state that you manage outside of the knowledge of the passmanager. In any case it should always be “correct” to ignore the calls to releaseMemory(), I believe this is just an optimization: it semantic AFAIK is that the pass manager signals it does not know of a pass that will use the result of this analysis, so it can be free’d now to reduce the peak memory. (In fact it is correct only if the runOnXXX() method can deal with the pass not being cleaned, but it does not matter for an immutable pass, it is never run). On the other hand, doFinalization() should always clear the internal state for correctness though (it depends on the kind of state you have, but as a general rule…). Hope this help. — Mehdi> > - Maxime > >> On Dec 8, 2016, at 4:13 PM, Mehdi Amini <mehdi.amini at apple.com <mailto:mehdi.amini at apple.com>> wrote: >> >> Hi, >> >> There are two relevant hooks for you immutable pass: >> >> 1) releaseMemory() >> 2) doFinalization() >> >> Are you looking at the first one? I think you should act on the second instead and it should solve your issue. >> >> — >> Mehdi >> >> >>> On Dec 8, 2016, at 10:58 AM, Maxime Chevalier-Boisvert via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >>> >>> We have our own subtarget, with its own pipeline and set of passes. >>> >>> The problem I’m facing, as explained, is that adding the DummyCGSCCPass to our pipeline causes an early pass to be finalized when it shouldn’t be. The information then becomes unavailable when needed, in the machine code generation part of our pipeline. >>> >>> It’s unclear to us why this is happening. I was hoping someone familiar with the pass manager may have advice, or that someone may have run into a similar problem before. >>> >>> - Maxime >>> >>>> On Dec 7, 2016, at 9:46 PM, vivek pandya via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote: >>>> >>>> >>>> >>>> Hello, >>>> >>>> I'm trying to enable interprocedural register allocation (IPRA). >>>> Hi Maxime, >>>> >>>> I don't understand here why you need to enable IPRA as that is already scheduled based on option -mllvm -enable-ipra. So I think easy way to make IPRA execute every time is to set default value of EnableIPRA option to true. >>>> you can find this option defined in lib/CodeGen/TargetMachine.cpp and you may also need to change its initialization to true in TargetOptions constructor in include/llvm/Target/TargetOptions.h >>>> >>>> - Vivek >>>> In order to do this, I’ve added the DummyCGSCCPass to our pipeline, as is done in TargetPassConfig::addISelPrepare. My understanding is that this pass wraps the following passes into an SCC pass manager, so that they are run in bottom-up order, which is necessary to enable register allocation info from callees to be available at call sites. >>>> >>>> The problem I’m running into is that we have an ImmutablePass which is run early in our pipeline (and needed in later machine code generation stages), and for some reason, this pass gets finalized and re-run multiple times, destroying the information we need in the process. I’m really not sure what is happening. The pass is clearly marked as required by later passes, but somehow it is found to be “dead”, finalized, and then re-run. To make matters more confusing, we have another ImmutablePass which is run early and used late, but this one doesn’t get finalized. My coworkers and I are really not sure what the difference might be. >>>> >>>> Could someone more familiar with IPRA or the PassManager provide some hints as to what might be happening? >>>> >>>> Regards, >>>> >>>> - Maxime >>>> _______________________________________________ >>>> LLVM Developers mailing list >>>> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> >>> >>> _______________________________________________ >>> LLVM Developers mailing list >>> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev> >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161208/af65b34b/attachment.html>