Viacheslav Nikolaev via llvm-dev
2016-Dec-02 09:03 UTC
[llvm-dev] Multithreading and RegisterHandlers
There was an issue reported a while ago http://lists.llvm.org/pipermail/llvm-dev/2014-February/070692.html but it is still not adressed. RegisterHandlers() is not thread safe and isn't called under locks for Unix... Is there any reason why RegisterHandlers() shouldn't be put under the scoped locks used before the invocations of the function? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161202/ff1d49e4/attachment.html>
Reid Kleckner via llvm-dev
2016-Dec-06 18:55 UTC
[llvm-dev] Multithreading and RegisterHandlers
Uh, yeah, that looks racy. I'd suggest guarding it in *SignalsMutex. I'd recommend filing a bug or sending a patch. On Fri, Dec 2, 2016 at 1:03 AM, Viacheslav Nikolaev via llvm-dev < llvm-dev at lists.llvm.org> wrote:> There was an issue reported a while ago > http://lists.llvm.org/pipermail/llvm-dev/2014-February/070692.html > > but it is still not adressed. RegisterHandlers() is not thread safe and > isn't called under locks for Unix... > > Is there any reason why RegisterHandlers() shouldn't be put under the > scoped locks used before the invocations of the function? > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161206/12ce305a/attachment.html>