Hi Andrew, Peter, I took a look at the results of running govet on the go bindings - there are a lot of small/simple problems that should probably be looked at. Wrong number of arguments a few times, shifts by > 32, etc. https://golang.org/cmd/vet/ Thanks! -eric -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160315/e7dd4e01/attachment.html>
On Wed, 16 Mar 2016 at 05:55 Eric Christopher <echristo at gmail.com> wrote:> Hi Andrew, Peter, > > I took a look at the results of running govet on the go bindings - there > are a lot of small/simple problems that should probably be looked at. Wrong > number of arguments a few times, shifts by > 32, etc. >Did you just run "go vet llvm.org/llvm/bindings/go"? No customisation? Which version of Go are you using? I get no warnings from vet (which, frankly, surprises me; the bindings are a mess). Cheers, Andrew https://golang.org/cmd/vet/> > Thanks! > > -eric >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160316/0c0e1f64/attachment.html>
On Tue, Mar 15, 2016 at 6:01 PM Andrew Wilkins <axwalk at gmail.com> wrote:> On Wed, 16 Mar 2016 at 05:55 Eric Christopher <echristo at gmail.com> wrote: > >> Hi Andrew, Peter, >> >> I took a look at the results of running govet on the go bindings - there >> are a lot of small/simple problems that should probably be looked at. Wrong >> number of arguments a few times, shifts by > 32, etc. >> > > Did you just run "go vet llvm.org/llvm/bindings/go"? No customisation? > Which version of Go are you using? I get no warnings from vet (which, > frankly, surprises me; the bindings are a mess). > >I did some looking and we're passing -printfuncs=Debug:0,Debugf:0,Info:0,Infof:0,Warning:0,Warningf:0,Exit:0,Exitf:0 to the tool. That help? :) -eric> Cheers, > Andrew > > https://golang.org/cmd/vet/ >> >> Thanks! >> >> -eric >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160322/7097b799/attachment.html>