Benjamin Kramer via llvm-dev
2016-Mar-10 17:07 UTC
[llvm-dev] Regression in SPEC2006/gcc caused by LoopLoadElimination
On Thu, Mar 10, 2016 at 1:17 AM, Adam Nemet <anemet at apple.com> wrote:> I’ve committed the fix in r263058. Haicheng, Eric/Benjamin, can you guys > please give it a test with your codebase. (You need to enable the pass with > -mllvm -enable-loop-load-elim.)The miscompilation I was seeing is gone now, too. Thanks!> On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com> wrote: > > > On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com> wrote: > > Hi Haicheng, > > Sorry about the breakage. I reverted it in r262839. > > I will try to reproduce it locally. Please don’t blow away your directories > yet in case I need further help. > > > OK, I managed to reproduce this locally. Should be able to make progress > from here without further help from you. > > Adam > > Thanks, > Adam > > On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org> wrote: > > Hi Adam, > > I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong > result (166.s) in AArch64 when running with *ref* data set. The error > happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3 > -fno-strict-aliasing”. Please let me know if you need more information. > > Best, > > Haicheng > > > >
Eric Christopher via llvm-dev
2016-Mar-10 17:20 UTC
[llvm-dev] Regression in SPEC2006/gcc caused by LoopLoadElimination
Or Ben will test. :) Thanks Adam! On Thu, Mar 10, 2016, 9:07 AM Benjamin Kramer <benny.kra at gmail.com> wrote:> On Thu, Mar 10, 2016 at 1:17 AM, Adam Nemet <anemet at apple.com> wrote: > > I’ve committed the fix in r263058. Haicheng, Eric/Benjamin, can you guys > > please give it a test with your codebase. (You need to enable the pass > with > > -mllvm -enable-loop-load-elim.) > > The miscompilation I was seeing is gone now, too. Thanks! > > > On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com> wrote: > > > > > > On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com> wrote: > > > > Hi Haicheng, > > > > Sorry about the breakage. I reverted it in r262839. > > > > I will try to reproduce it locally. Please don’t blow away your > directories > > yet in case I need further help. > > > > > > OK, I managed to reproduce this locally. Should be able to make progress > > from here without further help from you. > > > > Adam > > > > Thanks, > > Adam > > > > On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org> wrote: > > > > Hi Adam, > > > > I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong > > result (166.s) in AArch64 when running with *ref* data set. The error > > happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3 > > -fno-strict-aliasing”. Please let me know if you need more information. > > > > Best, > > > > Haicheng > > > > > > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160310/0d0783a5/attachment.html>
Adam Nemet via llvm-dev
2016-Mar-10 17:33 UTC
[llvm-dev] Regression in SPEC2006/gcc caused by LoopLoadElimination
Cool, thanks guys!> On Mar 10, 2016, at 9:20 AM, Eric Christopher <echristo at gmail.com> wrote: > > Or Ben will test. :) > > Thanks Adam! > > >> On Thu, Mar 10, 2016, 9:07 AM Benjamin Kramer <benny.kra at gmail.com> wrote: >> On Thu, Mar 10, 2016 at 1:17 AM, Adam Nemet <anemet at apple.com> wrote: >> > I’ve committed the fix in r263058. Haicheng, Eric/Benjamin, can you guys >> > please give it a test with your codebase. (You need to enable the pass with >> > -mllvm -enable-loop-load-elim.) >> >> The miscompilation I was seeing is gone now, too. Thanks! >> >> > On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com> wrote: >> > >> > >> > On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com> wrote: >> > >> > Hi Haicheng, >> > >> > Sorry about the breakage. I reverted it in r262839. >> > >> > I will try to reproduce it locally. Please don’t blow away your directories >> > yet in case I need further help. >> > >> > >> > OK, I managed to reproduce this locally. Should be able to make progress >> > from here without further help from you. >> > >> > Adam >> > >> > Thanks, >> > Adam >> > >> > On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org> wrote: >> > >> > Hi Adam, >> > >> > I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong >> > result (166.s) in AArch64 when running with *ref* data set. The error >> > happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3 >> > -fno-strict-aliasing”. Please let me know if you need more information. >> > >> > Best, >> > >> > Haicheng >> > >> > >> > >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160310/2fa174ef/attachment.html>
Adam Nemet via llvm-dev
2016-Mar-11 19:14 UTC
[llvm-dev] Regression in SPEC2006/gcc caused by LoopLoadElimination
Ben and Eric, Are you guys still running some tests or you’re done? Now that the two issues are fixed, I’d like to flip this on again. Thanks, Adam> On Mar 10, 2016, at 9:20 AM, Eric Christopher <echristo at gmail.com> wrote: > > Or Ben will test. :) > > Thanks Adam! > > > On Thu, Mar 10, 2016, 9:07 AM Benjamin Kramer <benny.kra at gmail.com <mailto:benny.kra at gmail.com>> wrote: > On Thu, Mar 10, 2016 at 1:17 AM, Adam Nemet <anemet at apple.com <mailto:anemet at apple.com>> wrote: > > I’ve committed the fix in r263058. Haicheng, Eric/Benjamin, can you guys > > please give it a test with your codebase. (You need to enable the pass with > > -mllvm -enable-loop-load-elim.) > > The miscompilation I was seeing is gone now, too. Thanks! > > > On Mar 7, 2016, at 11:05 PM, Adam Nemet <anemet at apple.com <mailto:anemet at apple.com>> wrote: > > > > > > On Mar 7, 2016, at 9:43 AM, Adam Nemet <anemet at apple.com <mailto:anemet at apple.com>> wrote: > > > > Hi Haicheng, > > > > Sorry about the breakage. I reverted it in r262839. > > > > I will try to reproduce it locally. Please don’t blow away your directories > > yet in case I need further help. > > > > > > OK, I managed to reproduce this locally. Should be able to make progress > > from here without further help from you. > > > > Adam > > > > Thanks, > > Adam > > > > On Mar 7, 2016, at 8:33 AM, Haicheng Wu <haicheng at codeaurora.org <mailto:haicheng at codeaurora.org>> wrote: > > > > Hi Adam, > > > > I find LoopLoadElimination (r262250) causes SPEC2006/gcc generate wrong > > result (166.s) in AArch64 when running with *ref* data set. The error > > happens when I use either “-Ofast -flto -fuse-ld=gold” or “-O3 > > -fno-strict-aliasing”. Please let me know if you need more information. > > > > Best, > > > > Haicheng > > > > > > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160311/7df4dceb/attachment.html>