Renato Golin via llvm-dev
2016-Jan-29 09:50 UTC
[llvm-dev] [cfe-dev] Proposal: Enable BUILD_SHARED_LIBS=ON by default for debug build.
Hi Yin, I second David's words. I use shared libs myself on debug builds, but static builds with gold on a local disk is pretty feasible. Before I used gold, I had to have 16GB of RAM on my laptop, now I need less than 8GB for static builds. On 28 January 2016 at 23:58, Yin Ma via cfe-dev <cfe-dev at lists.llvm.org> wrote:> It is O.K. I just hope BUILD_SHARED_LIBS=ON is tested when a patch is > merged. Yesterday, I found the tip failed to build with ON. Today, tip is > O.K to build in shared linking.This is a different matter, and as David said, one that may not be *that* critical, given to the number of people that use shared libs on debug builds. Chances are that ToT is ok now because someone fixed whatever the bug was, and not because of sheer luck. Don't worry too much about it. I see no reason to turn shared libs on by default on debug builds, given that it's just one command line option in CMake. Whatever the default state of that flag is, some people will have to have it, others won't. If you change the default, you'll force *everyone* to change their flags for no reason. cheers, --renato PS: Life is short, don't build stuff over NFS. :)
Yin Ma via llvm-dev
2016-Jan-29 18:13 UTC
[llvm-dev] [cfe-dev] Proposal: Enable BUILD_SHARED_LIBS=ON by default for debug build.
Hi Golin, Thank for your information. I will upgrade our host toolchain to improve building performance. Thanks, Yin -----Original Message----- From: Renato Golin [mailto:renato.golin at linaro.org] Sent: Friday, January 29, 2016 1:50 AM To: Yin Ma Cc: David Blaikie; Jonathan Roelofs; llvm-dev; cfe-dev Subject: Re: [cfe-dev] Proposal: Enable BUILD_SHARED_LIBS=ON by default for debug build. Hi Yin, I second David's words. I use shared libs myself on debug builds, but static builds with gold on a local disk is pretty feasible. Before I used gold, I had to have 16GB of RAM on my laptop, now I need less than 8GB for static builds. On 28 January 2016 at 23:58, Yin Ma via cfe-dev <cfe-dev at lists.llvm.org> wrote:> It is O.K. I just hope BUILD_SHARED_LIBS=ON is tested when a patch is > merged. Yesterday, I found the tip failed to build with ON. Today, tip > is O.K to build in shared linking.This is a different matter, and as David said, one that may not be *that* critical, given to the number of people that use shared libs on debug builds. Chances are that ToT is ok now because someone fixed whatever the bug was, and not because of sheer luck. Don't worry too much about it. I see no reason to turn shared libs on by default on debug builds, given that it's just one command line option in CMake. Whatever the default state of that flag is, some people will have to have it, others won't. If you change the default, you'll force *everyone* to change their flags for no reason. cheers, --renato PS: Life is short, don't build stuff over NFS. :)
Jack Howarth via llvm-dev
2016-Feb-13 17:54 UTC
[llvm-dev] [cfe-dev] Proposal: Enable BUILD_SHARED_LIBS=ON by default for debug build.
Yin, You might want to revisit this issue by trying -DLLVM_LINK_LLVM_DYLIB=ON (which isn't darwin specific cmake option despite its name). With the commit of r260641 in both trunk and 3.8 branch, all of the linkage glitches causing test suite regressions are now eliminated so the unified libLLVM shared library is now usable. Jack On Fri, Jan 29, 2016 at 1:13 PM, Yin Ma via llvm-dev <llvm-dev at lists.llvm.org> wrote:> Hi Golin, > > Thank for your information. I will upgrade our host toolchain to improve building performance. > > Thanks, > > Yin > > > -----Original Message----- > From: Renato Golin [mailto:renato.golin at linaro.org] > Sent: Friday, January 29, 2016 1:50 AM > To: Yin Ma > Cc: David Blaikie; Jonathan Roelofs; llvm-dev; cfe-dev > Subject: Re: [cfe-dev] Proposal: Enable BUILD_SHARED_LIBS=ON by default for debug build. > > Hi Yin, > > I second David's words. I use shared libs myself on debug builds, but static builds with gold on a local disk is pretty feasible. Before I used gold, I had to have 16GB of RAM on my laptop, now I need less than 8GB for static builds. > > > On 28 January 2016 at 23:58, Yin Ma via cfe-dev <cfe-dev at lists.llvm.org> wrote: >> It is O.K. I just hope BUILD_SHARED_LIBS=ON is tested when a patch is >> merged. Yesterday, I found the tip failed to build with ON. Today, tip >> is O.K to build in shared linking. > > This is a different matter, and as David said, one that may not be > *that* critical, given to the number of people that use shared libs on debug builds. > > Chances are that ToT is ok now because someone fixed whatever the bug was, and not because of sheer luck. Don't worry too much about it. > > I see no reason to turn shared libs on by default on debug builds, given that it's just one command line option in CMake. Whatever the default state of that flag is, some people will have to have it, others won't. If you change the default, you'll force *everyone* to change their flags for no reason. > > cheers, > --renato > > PS: Life is short, don't build stuff over NFS. :) > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev