Rafael Espíndola via llvm-dev
2016-Jan-15 00:19 UTC
[llvm-dev] Is MCRelocationInfo::createExprForRelocation used out of tree?
Deleting LGTM. It is a leftover of MCAnalysis. Cheers, Rafael On 14 January 2016 at 16:54, Pete Cooper <peter_cooper at apple.com> wrote:> Hi Jim, Rafael > > As respective code owner and frequent committer to MC, any thoughts on this? > > Cheers, > Pete >> On Jan 12, 2016, at 1:07 PM, Pete Cooper <peter_cooper at apple.com> wrote: >> >> Hi all >> >> The virtual method MCRelocationInfo::createExprForRelocation doesn’t appear to have any callers. Is anyone using it out of tree? >> >> In tree, its overridden in X86ELFRelocationInfo.cpp and X86MachORelocationInfo.cpp, but those overrides have 0% coverage (http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html) >> >> I’d like to delete these methods and files, assuming they aren’t somehow in use out of tree. >> >> Thoughts? >> >> Thanks, >> Pete >
Jim Grosbach via llvm-dev
2016-Jan-15 00:38 UTC
[llvm-dev] Is MCRelocationInfo::createExprForRelocation used out of tree?
Agreed. No internal uses here, either, that I’m aware of.> On Jan 14, 2016, at 4:19 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: > > Deleting LGTM. It is a leftover of MCAnalysis. > > Cheers, > Rafael > > > On 14 January 2016 at 16:54, Pete Cooper <peter_cooper at apple.com> wrote: >> Hi Jim, Rafael >> >> As respective code owner and frequent committer to MC, any thoughts on this? >> >> Cheers, >> Pete >>> On Jan 12, 2016, at 1:07 PM, Pete Cooper <peter_cooper at apple.com> wrote: >>> >>> Hi all >>> >>> The virtual method MCRelocationInfo::createExprForRelocation doesn’t appear to have any callers. Is anyone using it out of tree? >>> >>> In tree, its overridden in X86ELFRelocationInfo.cpp and X86MachORelocationInfo.cpp, but those overrides have 0% coverage (http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html) >>> >>> I’d like to delete these methods and files, assuming they aren’t somehow in use out of tree. >>> >>> Thoughts? >>> >>> Thanks, >>> Pete >>
Pete Cooper via llvm-dev
2016-Jan-15 02:28 UTC
[llvm-dev] Is MCRelocationInfo::createExprForRelocation used out of tree?
Thanks Jim and Rafael. Removed in r257859. Cheers, Pete> On Jan 14, 2016, at 4:38 PM, Jim Grosbach <grosbach at apple.com> wrote: > > Agreed. No internal uses here, either, that I’m aware of. > > >> On Jan 14, 2016, at 4:19 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote: >> >> Deleting LGTM. It is a leftover of MCAnalysis. >> >> Cheers, >> Rafael >> >> >> On 14 January 2016 at 16:54, Pete Cooper <peter_cooper at apple.com> wrote: >>> Hi Jim, Rafael >>> >>> As respective code owner and frequent committer to MC, any thoughts on this? >>> >>> Cheers, >>> Pete >>>> On Jan 12, 2016, at 1:07 PM, Pete Cooper <peter_cooper at apple.com> wrote: >>>> >>>> Hi all >>>> >>>> The virtual method MCRelocationInfo::createExprForRelocation doesn’t appear to have any callers. Is anyone using it out of tree? >>>> >>>> In tree, its overridden in X86ELFRelocationInfo.cpp and X86MachORelocationInfo.cpp, but those overrides have 0% coverage (http://llvm.org/reports/coverage/lib/Target/X86/MCTargetDesc/X86MachORelocationInfo.cpp.gcov.html) >>>> >>>> I’d like to delete these methods and files, assuming they aren’t somehow in use out of tree. >>>> >>>> Thoughts? >>>> >>>> Thanks, >>>> Pete >>> >