Robinson, Paul via llvm-dev
2015-Dec-22 19:11 UTC
[llvm-dev] [cfe-dev] Newbie question: phabricator reviewers?!
> -----Original Message----- > From: cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] On Behalf Of Andy > Gibbs via cfe-dev > Sent: Monday, December 21, 2015 1:43 AM > To: Jonathan; cfe-dev at lists.llvm.org > Subject: Re: [cfe-dev] Newbie question: phabricator reviewers?! > > On Monday 21 Dec 2015 09:20:51 Jonathan wrote: > > I've tended to read through the history of the files I'm changing to > collect > > a few reviewers. People seem happy to drop in or out as appropriate.I've added some advice on choosing reviewers in r256265, which essentially says what Jonathan said but using more words. :-) I know from personal experience that getting started with Phabricator can be a bit daunting! Hopefully the rest of it was sufficiently helpful. --paulr> > Thanks. I've chosen two, so hopefully that'll be ok. > > Cheers > Andy > > > _______________________________________________ > cfe-dev mailing list > cfe-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
Andy Gibbs via llvm-dev
2015-Dec-23 16:40 UTC
[llvm-dev] [cfe-dev] Newbie question: phabricator reviewers?!
On Tuesday 22 Dec 2015 19:11:34 Robinson, Paul wrote:> I've added some advice on choosing reviewers in r256265, which essentially > says what Jonathan said but using more words. :-) > > I know from personal experience that getting started with Phabricator can > be a bit daunting! Hopefully the rest of it was sufficiently helpful. > --paulrThanks, I think that will help people. I received three different recommendations in response to my original post, so the clarification is certainly good to have. Thanks again! Cheers Andy